fix: tab retargeting if focus moved during keydown#1296
Open
snowystinger wants to merge 1 commit intotesting-library:mainfrom
Open
fix: tab retargeting if focus moved during keydown#1296snowystinger wants to merge 1 commit intotesting-library:mainfrom
snowystinger wants to merge 1 commit intotesting-library:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes #1188
Why
This is how the browser behaves, if focus is moved during the keydown of "Tab", then focus is moved from the new activeElement
I came across this in our own repo while testing some new changes.
adobe/react-spectrum#8700
How
Instead of using event target, we used the known activeElement when determining where focus should move
Checklist