Skip to content

Comments

Fix json/csv output when STARTTLS problem is passed back (3.0)#2581

Merged
drwetter merged 1 commit into3.0from
fix_2575-3.0
Oct 14, 2024
Merged

Fix json/csv output when STARTTLS problem is passed back (3.0)#2581
drwetter merged 1 commit into3.0from
fix_2575-3.0

Conversation

@drwetter
Copy link
Collaborator

In rare cases testssl.sh writes to the terminal an output "likely not offered" but misses the "likely" in the json/csv output.

This fixes #2575 for 3.0 by adding that word and amending the return value 4 with a comment.

What is your pull request about?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Typo fix
  • Documentation update
  • Update of other files

If it's a code change please check the boxes which are applicable

  • For the main program: My edits contain no tabs and the indentation is five spaces
  • I've read CONTRIBUTING.md and Coding_Convention.md
  • I have tested this fix against >=2 hosts and I couldn't spot a problem
  • I have tested this new feature against >=2 hosts which show this feature and >=2 host which does not (in order to avoid side effects) . I couldn't spot a problem
  • For the new feature I have made corresponding changes to the documentation and / or to help()
  • If it's a bigger change: I added myself to CREDITS.md (alphabetical order) and the change to CHANGELOG.md

In rare cases testssl.sh writes to the terminal output "likely not offered" but misses the "likely" in the json/csv output.

This fixes #2575 for the 3.0 branch by adding that word and amending the return value 4 with a comment.
@drwetter drwetter merged commit 6570c20 into 3.0 Oct 14, 2024
@drwetter drwetter deleted the fix_2575-3.0 branch October 14, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant