Fix check for OpenSSL supported curves#2662
Merged
drwetter merged 1 commit intotestssl:3.2from Feb 20, 2025
Merged
Conversation
OpenSSL 3.X outputs a different error message than previous versions when $OPENSSL s_client -curves X ... is called with an unsupported curve. This was resulting in the check within find_openssl_binary() adding every curve to $OPENSSL_SUPPORTED_CURVES, even ones that were not supported. This commit changes to check in order to detect the new error message.
Collaborator
|
Excellent & thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
OpenSSL 3.X outputs a different error message than previous versions when
$OPENSSL s_client -curves X ...is called with an unsupported curve. This was resulting in the check withinfind_openssl_binary()adding every curve to$OPENSSL_SUPPORTED_CURVES, even ones that were not supported. This PR changes to check in order to detect the new error message.I have tested the fix against multiple versions of OpenSSL/LibreSSL and verified that
$OPENSSL_SUPPORTED_CURVESis being set correctly.What is your pull request about?
If it's a code change please check the boxes which are applicable
help()