Squash some shellcheck *errors* #2922
Merged
+42
−40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and some warnings.
One of the latter being export was a variable. It obviously worked the past years. For the sake of cleaner code I renamed those occurrences.
Five errors of type SC2145 are left as I am not sure whether it'll be safe to follow the recommendation.
@dcooper16 : Can we safely change that?
Describe your changes
Please refer to an issue here or describe the change thoroughly in your PR.
What is your pull request about?
If it's a code change please check the boxes which are applicable
help()