Auto Magazine Ejection Works for Irremovable Attachments #18067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Quality of Life
ivanmixo
requested changes
Jul 8, 2025
|
I guess the other option would be to copy-paste the verb and only allow it to work if the underbarrel attachment can make use of it. |
|
yeah don't do it this way. Make the toggle verb check if the underbarrel is even valid for autoeject or not (presumably its just this, plasma pistol and tx54), then give you a list so you can choose which one you are actually trying to toggle. |
Runian
changed the title
…ov-Marine-Corps into sg153-deattachable
Lumipharon
approved these changes
Jul 9, 2025
TiviPlus
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
The verb "Toggle Automatic Magazine Ejection (Weapon)" now gives a choice of which weapon and/or attachment to toggle if there is more than one possible item that can make use of it.
Why It's Good For The Game
The ability to toggle auto-eject mags is locked behind having to actually hold the attachment in your hand. Some attachments are irremovable which makes it impossible to normally toggle automatic magazine ejection. This fixes that.
Changelog
🆑
qol: Toggle Automatic Magazine Ejection (Weapon) now lets you choose between your weapon and the weapon's attachments.
/:cl: