feat(synced-lyrics): lyrics offset

[scratchusernamemrtbts]

Resolves #3237
please give me feedback on the labels and tooltips cus i am not a native english speaker
also right now positive offset means that lyrics show slower than the audio (used with bluetooth speakers which i think is the best usecase for this feature rn)
and negative might be used when the lyrics it pulled timestamp is offset slower than the actual song
might want to swap that but lmk which is best

[Copilot]

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (1)

• src/i18n/resources/en.json: Language not supported

Comments suppressed due to low confidence (1)

src/plugins/synced-lyrics/menu.ts:17

• [nitpick] The label and tooltip keys for the lyrics offset feature should clearly indicate its behavior. Consider updating the translation text to explicitly mention that a positive offset delays lyric display (lyrics show slower than audio) and a negative offset accelerates them, ensuring consistency with the feature description.

label: t('plugins.synced-lyrics.menu.offset.label'),

[ArjixWasTaken]

Hello @scratchusernamemrtbts , would you be interested in inviting me to your fork so I can enhance this further?
I would like to add a way of changing the offset directly from the lyrics panel, instead of having to go to the menu settings.

---

I could of course do that on a follow-up PR, this ain't a dealbreaker

[scratchusernamemrtbts]

Hello @scratchusernamemrtbts , would you be interested in inviting me to your fork so I can enhance this further? I would like to add a way of changing the offset directly from the lyrics panel, instead of having to go to the menu settings.

I could of course do that on a follow-up PR, this ain't a dealbreaker

i'm so sorry for just seeing this now
i've just invited you to my fork now

[ArjixWasTaken]

@scratchusernamemrtbts

I am quite satisfied with an implementation like this, because it allows for more complex options in the lyrics picker, w/o bloating the UI.

picker-offset.mp4

what do you think?

(ofc the CSS has to be improved)

[scratchusernamemrtbts]

not sure if the three dots provide a clear indication that it's for lyrics offset
(maybe a timer symbol)

[ArjixWasTaken]

not sure if the three dots provide a clear indication that it's for lyrics offset (maybe a timer symbol)

The three dots are not for the offset, but for "advanced options"

because it allows for more complex options in the lyrics picker, w/o bloating the UI.

[ArjixWasTaken]

Final design I can come up with

some minor changes should be made so it feels less rough, but other than that I am satisfied with it

[ArjixWasTaken]

PS: There is a weird bug when the lyricsOffset is updated using the original menu.

[scratchusernamemrtbts]

apparently the counter prompt type doesn't handle negative numbers correctly so I've also changed the prompt type to a normal input instead

[scratchusernamemrtbts]

PS: There is a weird bug when the lyricsOffset is updated using the original menu.

Not sure if this is the bug your talking about but i made the ui update when changing the config through the menu prompt

[scratchusernamemrtbts]

also if anyone's got a better solution than this please lmk

[ArjixWasTaken]

I will be rebasing on master later this day week month, since I am the most familiar with the changes.

Edit: 😭

[ArjixWasTaken]

Some slight CSS changes still need to be done after the rebase.

@scratchusernamemrtbts can you convert this into a draft for now?