Add Slack Now Playing plugin #3242

curtisgibby · 2025-04-15T18:19:01Z

I wanted to be able to push my "Now Playing" status to my company's Slack.

JellyBrick · 2025-04-21T07:04:42Z

It would be better to separate the Slack scrobbler as a standalone plugin, similar to the Discord RPC. The Scrobbler plugin is intended for services like LastFM or Listenbrainz.

ArjixWasTaken · 2025-04-21T22:08:08Z

~~This is more akin to discord rich presence than scrobbling.~~ (I hadn't read Jelly's message which says the same thing)
Maybe we could make a more generic plugin that supports multiple social media platforms?

e.g. Rich Presence or smth like that

curtisgibby · 2025-04-22T14:40:02Z

OK, I'll rework this as a standalone plugin.

- Add isSlackNowPlayingConfig type guard function for better type checking - Replace unsafe type assertions with proper type guards

… error handling

…alog

…-playing plugin

…Slack API client

ArjixWasTaken · 2025-05-09T22:06:55Z

I wouldn't recommend adding a dependency like axios, especially in 2025, when the built-in fetch is as good.

…node in Slack client

ArjixWasTaken · 2025-05-10T23:06:13Z

Why the extra dependency for formdata?

src/plugins/slack-now-playing/main.ts

curtisgibby · 2025-05-10T23:29:04Z

Why the extra dependency for formdata?

That was a leftover when I was trying formdata instead of formdata-node. Removed now.

src/plugins/slack-now-playing/main.ts

ArjixWasTaken · 2025-05-10T23:44:08Z

package.json

    "filenamify": "6.0.0",
+    "formdata-node": "^6.0.3",


ArjixWasTaken · 2025-05-10T23:44:24Z

package.json

@@ -273,7 +273,10 @@
    "es-hangul": "2.3.3",
    "fast-average-color": "9.5.0",
    "fast-equals": "5.2.2",
+    "fetch-blob": "^4.0.0",


here as well?

ArjixWasTaken · 2025-05-10T23:44:47Z

why so many polyfills?
we are using a modern version of Nodejs that supports all those out of the box

…pport

src/plugins/slack-now-playing/main.ts

curtisgibby · 2025-05-17T21:10:35Z

I believe that I've addressed all of the feedback that you've given. If there's something I've missed, or a new issue, please let me know.

ArjixWasTaken · 2025-05-18T12:58:22Z

It would be hypocritical of me to say this in another PR and not here as well, so here we go.

#3376 (comment)

Why are you providing translations?
Translations are meant to be contributed using weblate.

Please do not use Google Translate/AI for translations.

curtisgibby · 2025-05-18T21:10:40Z

Please do not use Google Translate/AI for translations.

Reverted all languages except EN & ES (since I speak those languages and know that the meaning is correct).

feat: Add slack scrobbler

d2a3faa

JellyBrick added the enhancement New feature or request label Apr 21, 2025

curtisgibby added 16 commits May 9, 2025 09:51

(feat) Move Slack Now Playing to its own plugin

d023aaf

(fix) Remove unneeded imports and debug logging

b7f7e73

Add i18n for Slack Now Playing plugin

bbb6685

(i18n) Update plugin name and status text to use different languages

7a5de99

(i18n) Add localizations for Slack Now Playing

caf25a3

Merge master into slack-now-playing branch

747e075

Fix newlines

a970185

chore: revert leftover changes to scrobbler plugin

839e21a

refactor(slack-now-playing): improve type safety with proper type guards

21eb5ac

- Add isSlackNowPlayingConfig type guard function for better type checking - Replace unsafe type assertions with proper type guards

feat: enhance error handling and logging in Slack Now Playing plugin

8b757d6

feat: add album art caching and temporary file cleanup for Slack plugin

38d964a

refactor: improve Slack API error handling and response typing

7c468dc

feat: add caching and rate limiting to Slack API client with improved…

d560ed2

… error handling

feat: add help text and improve layout of Slack Now Playing config di…

d1c329b

…alog

refactor: remove unnecessary console logs and whitespace in slack-now…

04b86e4

…-playing plugin

chore: rename Slack Status to Slack Now Playing in English translations

ec9a8e4

curtisgibby changed the title ~~Add slack scrobbler~~ Add Slack Now Playing plugin May 9, 2025

feat: add SSL certificate validation bypass for local development in …

b75c24d

…Slack API client

refactor: replace axios and form-data with native fetch and formdata-…

af5e58e

…node in Slack client

ArjixWasTaken reviewed May 10, 2025

View reviewed changes

src/plugins/slack-now-playing/main.ts Outdated Show resolved Hide resolved

curtisgibby added 2 commits May 10, 2025 17:19

refactor: Use unknown instead of any

a8350ec

chore: remove unused @types/form-data dependency

7e89a0d

ArjixWasTaken reviewed May 10, 2025

View reviewed changes

src/plugins/slack-now-playing/main.ts Outdated Show resolved Hide resolved

ArjixWasTaken reviewed May 10, 2025

View reviewed changes

package.json Outdated

"filenamify": "6.0.0",

"formdata-node": "^6.0.3",

Copy link

Contributor

ArjixWasTaken May 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here

ArjixWasTaken reviewed May 10, 2025

View reviewed changes

curtisgibby added 2 commits May 17, 2025 13:58

refactor: Use native JS APIs to send emoji to Slack

94910d6

fix: handle FormData file upload in environments without File/Blob su…

8a68034

…pport

ArjixWasTaken reviewed May 17, 2025

View reviewed changes

src/plugins/slack-now-playing/main.ts Outdated Show resolved Hide resolved

curtisgibby added 3 commits May 17, 2025 14:56

chore: remove file-type dependency from package.json

2e287c7

Update pnpm-lock.yaml

1fff670

refactor: simplify image file creation by removing Blob fallback

5d4c531

curtisgibby added 2 commits May 18, 2025 15:01

(i18n) Revert changes to most language files

97e928e

Merge remote-tracking branch 'upstream/master' into slack-now-playing

4aab863

refactor: remove unnecessary fetch options comment in slack API client

4eb1211

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add Slack Now Playing plugin #3242

Add Slack Now Playing plugin #3242

Uh oh!

curtisgibby commented Apr 15, 2025

Uh oh!

JellyBrick commented Apr 21, 2025

Uh oh!

ArjixWasTaken commented Apr 21, 2025 •

edited

Loading

Uh oh!

curtisgibby commented Apr 22, 2025

Uh oh!

ArjixWasTaken commented May 9, 2025

Uh oh!

ArjixWasTaken commented May 10, 2025

Uh oh!

Uh oh!

curtisgibby commented May 10, 2025

Uh oh!

Uh oh!

ArjixWasTaken May 10, 2025

Uh oh!

ArjixWasTaken May 10, 2025

Uh oh!

ArjixWasTaken commented May 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

curtisgibby commented May 17, 2025

Uh oh!

ArjixWasTaken commented May 18, 2025 •

edited

Loading

Uh oh!

curtisgibby commented May 18, 2025

Uh oh!

Uh oh!

Add Slack Now Playing plugin #3242

Are you sure you want to change the base?

Add Slack Now Playing plugin #3242

Uh oh!

Conversation

curtisgibby commented Apr 15, 2025

Uh oh!

JellyBrick commented Apr 21, 2025

Uh oh!

ArjixWasTaken commented Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

curtisgibby commented Apr 22, 2025

Uh oh!

ArjixWasTaken commented May 9, 2025

Uh oh!

ArjixWasTaken commented May 10, 2025

Uh oh!

Uh oh!

curtisgibby commented May 10, 2025

Uh oh!

Uh oh!

ArjixWasTaken May 10, 2025

Choose a reason for hiding this comment

Uh oh!

ArjixWasTaken May 10, 2025

Choose a reason for hiding this comment

Uh oh!

ArjixWasTaken commented May 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

curtisgibby commented May 17, 2025

Uh oh!

ArjixWasTaken commented May 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

curtisgibby commented May 18, 2025

Uh oh!

Uh oh!

ArjixWasTaken commented Apr 21, 2025 •

edited

Loading

ArjixWasTaken commented May 10, 2025 •

edited

Loading

ArjixWasTaken commented May 18, 2025 •

edited

Loading