-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Prioritize synced lyrics and improved artist value for lyrics on videos #3254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Nice idea, but ontop of that I propose you construct an array of all the queries to be made, and iterate over it. e.g. const queries = [`${info.artist} - ${info.title}`];
if (info.alternativeTitle) queries.push(`${info.artist} - ${info.alternativeTitle}`);
if (info.album) {
queries.push(`${info.album} - ${info.title}`);
if (info.alternativeTitle) queries.push(`${info.album} - ${info.alternativeTitle}`);
}
let lyrics = null;
for (const query of queries) {
const results = await ...;
lyrics = ...;
if (lyrics) break;
}
... heck, you may even gather all the search results from all the queries and do the filter on all of them |
To put my two cents here, I've done a quick test on your branch and the fixes from my PR seem to still work in the songs I tested, however I noticed the searching for LRCLIB seem to be much slower. Might just be me not noticing before though I'll look into it further if I have the time. |
TODO: Prioritize album name using jaroWinkler BIGBANG - Fantastic Baby |
# Conflicts: # src/plugins/synced-lyrics/providers/LRCLib.ts
Hi
With the artist value i achive to resolve #3117
And prioritize lyrics improve a bit #3206
Ex. starseed was displaying the plain lyrics
This is my very first PR, let me know if somethings is wrong.