feat(scrobblers): Only broadcast the main artist to Last.fm #3358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Songs on Last.fm only have the main artist set, and including any featured artists hinders Last.fm's song detection
JellyBrick
added
enhancement
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Last.fm scrobbler to send only the main artist name by stripping out featured or additional artists.
- Use a regex to extract the primary artist before any
&,,, orfeaturingsegment. - No other functional changes.
Comments suppressed due to low confidence (1)
src/plugins/scrobbler/services/lastfm.ts:138
- Add unit tests for various artist strings (e.g., multiple separators, different casing, parentheses) to verify that the regex correctly extracts the main artist in all cases.
artist: songInfo.artist.replace(/(.*?)(?:&|,|featuring).*$/, "$1"),
| @@ -135,7 +135,7 @@ export class LastFmScrobbler extends ScrobblerBase { | |||
| const postData: LastFmSongData = { | |||
| track: title, | |||
| duration: songInfo.songDuration, | |||
| artist: songInfo.artist, | |||
| artist: songInfo.artist.replace(/(.*?)(?:&|,|featuring).*$/, "$1"), | |||
There was a problem hiding this comment.
Consider making the regex case-insensitive (add the i flag) and including common shorthand patterns like feat\. or ft\. to cover more variations. Also trim the result to remove trailing whitespace.
Suggested change
| artist: songInfo.artist.replace(/(.*?)(?:&|,|featuring).*$/, "$1"), | |
| artist: songInfo.artist.replace(/(.*?)(?:&|,|featuring|feat\.|ft\.).*$/i, "$1").trim(), |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Songs on Last.fm only have the main artist set, and including any featured artists hinders Last.fm's song detection
Despite a song having multiple artists, Last.fm only considers the main artist as the "Artist" of the song.