Delete unused ctx

Signed-off-by: SungJin1212 <[email protected]>
thanos-io · Jan 9, 2025 · b33dea0 · b33dea0
1 parent 1dfcdc1
commit b33dea0
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 9 deletions.
diff --git a/execution/aggregate/hashaggregate.go b/execution/aggregate/hashaggregate.go
@@ -46,7 +46,6 @@ type aggregate struct {
 }
 
 func NewHashAggregate(
-	ctx context.Context,
 	points *model.VectorPool,
 	next model.VectorOperator,
 	paramOp model.VectorOperator,
@@ -56,7 +55,7 @@ func NewHashAggregate(
 	opts *query.Options,
 ) (model.VectorOperator, error) {
 	// Verify that the aggregation is supported.
-	if _, err := newScalarAccumulator(ctx, aggregation); err != nil {
+	if _, err := newScalarAccumulator(aggregation); err != nil {
 		return nil, err
 	}
 
@@ -267,7 +266,7 @@ func (a *aggregate) initializeScalarTables(ctx context.Context) ([]aggregateTabl
 
 		inputCache[i] = output.ID
 	}
-	tables, err := newScalarTables(ctx, a.stepsBatch, inputCache, outputCache, a.aggregation)
+	tables, err := newScalarTables(a.stepsBatch, inputCache, outputCache, a.aggregation)
 	if err != nil {
 		return nil, nil, err
 	}

diff --git a/execution/aggregate/scalar_table.go b/execution/aggregate/scalar_table.go
@@ -44,10 +44,10 @@ type scalarTable struct {
 	accumulators []accumulator
 }
 
-func newScalarTables(ctx context.Context, stepsBatch int, inputCache []uint64, outputCache []*model.Series, aggregation parser.ItemType) ([]aggregateTable, error) {
+func newScalarTables(stepsBatch int, inputCache []uint64, outputCache []*model.Series, aggregation parser.ItemType) ([]aggregateTable, error) {
 	tables := make([]aggregateTable, stepsBatch)
 	for i := 0; i < len(tables); i++ {
-		table, err := newScalarTable(ctx, inputCache, outputCache, aggregation)
+		table, err := newScalarTable(inputCache, outputCache, aggregation)
 		if err != nil {
 			return nil, err
 		}
@@ -60,10 +60,10 @@ func (t *scalarTable) timestamp() int64 {
 	return t.ts
 }
 
-func newScalarTable(ctx context.Context, inputSampleIDs []uint64, outputs []*model.Series, aggregation parser.ItemType) (*scalarTable, error) {
+func newScalarTable(inputSampleIDs []uint64, outputs []*model.Series, aggregation parser.ItemType) (*scalarTable, error) {
 	accumulators := make([]accumulator, len(outputs))
 	for i := 0; i < len(accumulators); i++ {
-		acc, err := newScalarAccumulator(ctx, aggregation)
+		acc, err := newScalarAccumulator(aggregation)
 		if err != nil {
 			return nil, err
 		}
@@ -173,7 +173,7 @@ func hashMetric(
 	return key, builder.Labels()
 }
 
-func newScalarAccumulator(ctx context.Context, expr parser.ItemType) (accumulator, error) {
+func newScalarAccumulator(expr parser.ItemType) (accumulator, error) {
 	t := parser.ItemTypeStr[expr]
 	switch t {
 	case "sum":

diff --git a/execution/execution.go b/execution/execution.go
@@ -274,7 +274,7 @@ func newAggregateExpression(ctx context.Context, e *logicalplan.Aggregation, sca
 	if e.Op == parser.TOPK || e.Op == parser.BOTTOMK {
 		next, err = aggregate.NewKHashAggregate(model.NewVectorPool(opts.StepsBatch), next, paramOp, e.Op, !e.Without, e.Grouping, opts)
 	} else {
-		next, err = aggregate.NewHashAggregate(ctx, model.NewVectorPool(opts.StepsBatch), next, paramOp, e.Op, !e.Without, e.Grouping, opts)
+		next, err = aggregate.NewHashAggregate(model.NewVectorPool(opts.StepsBatch), next, paramOp, e.Op, !e.Without, e.Grouping, opts)
 	}
 	if err != nil {
 		return nil, err