plan,engine: add partition labels #569
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaHoffmann
commented
May 21, 2025
| @@ -45,6 +45,10 @@ func (l remoteEngine) LabelSets() []labels.Labels { | |||
| return l.labelSets | |||
| } | |||
|
|
|||
| func (l remoteEngine) PartitionLabelSets() []labels.Labels { | |||
| return l.labelSets | |||
There was a problem hiding this comment.
This is a safe default. Engines who want to specify different partition labels can implement RemoteEngine differently.
fpetkovski
reviewed
May 21, 2025
Add a "PartitionLabelSets" method to remote engine api. This makes sense since a remote engine can have a big labelset but we only need a subset of those to actually perform a partition of all engines. Operating on a smaller labelset there helps us pushing down more expressions, since we know if we lose one of the unimportant labels from the labelset we can still keep pushing down. Signed-off-by: Michael Hoffmann <[email protected]>
MichaHoffmann
force-pushed
the
mhoffmann/add-partition-labels
branch
from
960f4d1 to
f49bd2f
Compare
harry671003
reviewed
May 30, 2025
| @@ -57,7 +57,7 @@ func TestDistributedExecution(t *testing.T) { | |||
| expr: `sum by (pod) (rate(http_requests_total[5m]))`, | |||
| expected: ` | |||
| sum by (pod) (dedup( | |||
| remote(sum by (pod, region) (rate(http_requests_total[5m]))), | |||
| remote(sum by (pod, region) (rate(http_requests_total[5m]))), | |||
There was a problem hiding this comment.
Should we add a test case where the PartitionLabelSets() and LabelSets() are different?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a "PartitionLabelSets" method to remote engine api. This makes sense since a remote engine can have a big labelset but we only need a subset of those to actually perform a partition of all engines. Operating on a smaller labelset there helps us pushing down more expressions, since we know if we lose one of the unimportant labels from the labelset we can still keep pushing down.