-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMPROVEMENT]Fix Typo's in recieve.md #5631
Conversation
Signed-off-by: rajivharlalka <[email protected]>
@matej-g can you take a look on why the CI failed this time. Thank you. |
Have you tried make docs locally? |
I ran it in my last PR #5621 , where the problem persisted.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rajivharlalka, try to push an empty commit. You can create an empty commit with git commit -s --allow-empty -m "Retrigger CI"
and then push it
Signed-off-by: rajivharlalka <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🙂
Some comments!
Co-authored-by: Saswata Mukherjee <[email protected]> Signed-off-by: Rajiv Harlalka <[email protected]>
Co-authored-by: Saswata Mukherjee <[email protected]> Signed-off-by: Rajiv Harlalka <[email protected]>
Signed-off-by: rajivharlalka <[email protected]>
Just a thought, isnt a 8-9 min CI run just to check if documentation very long? |
Yup, it is kind of long (actual docs checker job runs for ~5m)! We run a tool called
This takes some time, but the main source of latency is link checking. There are limits to how fast you can make requests, as websites would have ddos protections + GitHub Actions machines share IP addresses. We can try playing around with some of the params in Another solution can be to just run the check on main, but then a contributor would need to always raise new PR to fix, instead of just pushing commit to existing PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ah
Ah, I see. Truly the checks are great. Especially checking if the links are correct, helps to mitigate future issues at every PR. MDox sounds interesting :p . |
Signed-off-by: Matej Gera <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes 👍
(Merging without tests CI since only docs change) |
* update recieve.md doc Signed-off-by: rajivharlalka <[email protected]> * Retrigger CI Signed-off-by: rajivharlalka <[email protected]> * Update docs/components/receive.md Co-authored-by: Saswata Mukherjee <[email protected]> Signed-off-by: Rajiv Harlalka <[email protected]> * Update docs/components/receive.md Co-authored-by: Saswata Mukherjee <[email protected]> Signed-off-by: Rajiv Harlalka <[email protected]> * fix recieve readme white-spaces Signed-off-by: rajivharlalka <[email protected]> Signed-off-by: rajivharlalka <[email protected]> Signed-off-by: Rajiv Harlalka <[email protected]> Signed-off-by: Matej Gera <[email protected]> Co-authored-by: Saswata Mukherjee <[email protected]> Co-authored-by: Matej Gera <[email protected]>
Signed-off-by: rajivharlalka [email protected]
Changes
Fixed some typo in
recieve.md
.Verification