-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP : Update Navigation #1036
base: main
Are you sure you want to change the base?
WIP : Update Navigation #1036
Conversation
.deploy to development |
|
.deploy to development |
Deployment Triggered 🚀Razzmatazzz, started a branch deployment to development (branch: You can watch the progress here 🔗 Details{
"type": "branch",
"environment": {
"name": "development",
"url": null
},
"deployment": {
"timestamp": "2025-01-22T22:44:13.725Z",
"logs": "https://github.com/the-hideout/tarkov-dev/actions/runs/12918455745"
},
"git": {
"branch": "19b7ee855d36b8ae8106d74e21907753087e8806",
"commit": "19b7ee855d36b8ae8106d74e21907753087e8806",
"verified": false
},
"context": {
"actor": "Razzmatazzz",
"noop": false,
"fork": true,
"comment": {
"created_at": "2025-01-22T22:43:51Z",
"updated_at": "2025-01-22T22:43:51Z",
"body": ".deploy to development",
"html_url": "https://github.com/the-hideout/tarkov-dev/pull/1036#issuecomment-2608419557"
}
},
"parameters": {
"raw": null,
"parsed": null
}
} |
Deployment Results ✅Razzmatazzz successfully deployed branch Show ResultsDetails{
"status": "success",
"environment": {
"name": "development",
"url": null
},
"deployment": {
"id": 2134906202,
"timestamp": "2025-01-22T22:46:06.405Z",
"logs": "https://github.com/the-hideout/tarkov-dev/actions/runs/12918455745",
"duration": 113
},
"git": {
"branch": "19b7ee855d36b8ae8106d74e21907753087e8806",
"commit": "19b7ee855d36b8ae8106d74e21907753087e8806",
"verified": false
},
"context": {
"actor": "Razzmatazzz",
"noop": false,
"fork": true
},
"reviews": {
"count": 1,
"decision": "APPROVED"
},
"parameters": {
"raw": null,
"parsed": null
}
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deployed here for previewing: https://preview.tarkov-dev.pages.dev/settings/
One thing I notice right away is that it's not workable to have the menu collapse according to specific pixel widths because we can't be sure how much width each menu item will take up due to localization. For example, if you switch the site language to ru
, some window widths drive the remote and settings buttons off the screen. This is a large part of the reason behind the current "dynamic" system of shunting menu items to the overflow menu once they become too long: it works with all localizations, regardless of how many characters each menu item ends up being.
Good point, As discussed we don't really want to disrupt the menu too much, and I'm not in a rush to get this stuff merged in, so we have some good time for community feedback |
For sure. There are some good improvements here, and it will likely fix #791 as well. The trick is finding a good balance that doesn't stick often-used pages deep into nested menus and also works with the varying element widths inherent with all the different translations. |
Navigation Rework
Description 🗒️
Builds locally.
Examples 📸
Desktop
Mobile Menu Closed
Mobile Menu Open