Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.4.2 quick fix - cut and paste error #97

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

robert-kinder
Copy link
Contributor

I assume this is a cut and paste error (reference to services on Gov.UK)

Updating my repository 2019-12-11
I assume a cut and paste error
Copy link
Contributor

@jfhector jfhector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted @robert-kinder.

Rather than delete the point altogether, I think that it'd be better to modify it. Eg

The title does not indicate that the page is part of a website;

@robert-kinder
Copy link
Contributor Author

The title does not indicate that the page is part of a website;

@jfhector - Do you have any examples of this being done well or badly?

I hadn't really thought about the original comment beforehand, but (other than consistent text formatting) how does a title indicate it is part of Gov.UK/a website?

@jfhector
Copy link
Contributor

jfhector commented Jan 2, 2020

@robert-kinder thanks for asking, it prods me to put it in writing :) This is what I mean. I wrote it so we can use it in the guidelines. Let me know if it doesn't make sense. Feel free to add it to the doc yourself if you agree.

I've added a sub-section within 'Requirements' with best practices. Because the 'common mistake' example we're talking about is not a 'conformance issue' (i.e. it's not a failure to do what's included in the WCAG success criterion), it's a UX issue.

Requirements

...

Doing better than the minimum

Web-only best practices

  • The title should indicate what's on the page as well as the name of the website/service the page is part of.

Common mistakes

...

  • The title doesn't indicate the name of the website that the page is part of.

...

@robert-kinder
Copy link
Contributor Author

robert-kinder commented Jan 2, 2020

Hmmm... I think I'm starting to get out of my depth.

Based solely on your examples, from a non-technical perspective I think saying hyperlink text would be clearer than title.

However, I just checked the GOV.UK website and noticed that the HTML Title Tag follows your format and is not identical to the heading/title text at the top of the web page (what I would call a 'Page Title'):

Screenshot 2020-01-02 at 11 51 45

I'm starting to feel out of my depth because I don't know why, or understand the implications of this.

However, for the sake of the guidelines, I guess my questions are:

  1. Are Android and iOS the same as web (i.e. there is a coded 'Title' tag which is not identical to the text displayed at the top of the page)? If not, would it be worth calling this a 'Web Only Requirement'?
  2. Is there a way of making it clearer when we are referring to the the coded 'Title' tag and not the heading/title text at the top of the page?

@jfhector
Copy link
Contributor

jfhector commented Jan 2, 2020

Thanks, this is very useful. Your comments and questions helped me realise that there's a problem here. I've opened an issue.

Adding back the requirement for `<title>` elements to indicate that they're part of a wider website (but in the guidance for web section)
Strengthen the wording around the title element
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants