Fix "pardon the interruption" popup block #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We must no longer "pardon the interruption" -- now we can "extend our stay" and so on. The <h1> text in this popup changed, and there seems to be a few titles that get displayed. So now we look to the <h2> instead for blocking the _readus interruptus_ popup.
|
Seems to target it correctly, however at least on https://medium.com/mergify/automatic-merge-of-github-security-fixes-87d7781140c0 I see basically the animation still before it vanishes. But that doesn't seem to happen for all articles, somehow. It feels it has to do with how fast the page loads, so the basically the images there delaying the load somewhat. |
Medium changed some things; this fixes it again.
|
Yeah, I'm not sure how to get rid of the animation unfortunately. But this at least hides it for now |
|
Do you plan on merging/releasing this any time soon? |
|
These changes don't completely fix the issue anymore -- Medium is still making all kinds of changes that invalidate work here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We must no longer "pardon the interruption" -- now we can "extend our
stay" and so on. The <h1> text in this popup changed, and there seems to
be a few titles that get displayed. So now we look to the <h2> instead
for blocking the readus interruptus popup.
This fixes #51.