-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Support for using attribute as a target to parameter… #75
✨ Support for using attribute as a target to parameter… #75
Conversation
…ng as a target to the method. Add warning about next major release changes Refs: thecodingmachine/graphqlite#708 (comment)
Hey @andrew-demb , thanks for all the work and investigiatoins you've done in past several days! That's very appreciated! I could be wrong as I've lost the track of all the reasoning of addressing each problem so my comment could be negligible. But |
@SCIF I was thinking that dropping doctrine/annotations was not released yet. I need to double-check current versions of graphqlite then and will update the PR. Thanks |
@SCIF commit with dropping doctrine/annotations is not a part of any stable release yet. PR about removing doctrine/annotations dated 2024-04-13. Latest stable release dated 2024-03-20. So, I tried to make my best to simplify the upgrade path for users of this library. |
Yep, it was not released but committed into the master already, so anyway cleaning of attributes worth to be done and |
@SCIF validator-bridge library can be used without We don't know what version will be used to tag changes in dev-master - 7.1 or 8.0. So preserving compatibility with doctrine/annotations here allows to use bridge with graphqlite 7.0.0 |
The last, but not least, preserving compatibility with doctrine/annotations is pretty easy for the validator bridge. |
@nguyenk are you OK with PR? Merging this PR will allow devs to start upgrading to the "non-deprecated" way to work with parameter annotations with graphiql. |
@mistraloz can you help release this PR, please (and this one #76)? Or hint at whom we can ping to ask for help. Both PR's are backward compatible. |
…Deprecate using as a target to the method. Add warning about next major release changes
These changes can be released with a minor tag release (introduced new feature).
Refs: thecodingmachine/graphqlite#708 (comment)