Support both Symfony 6 and 7 #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enricobono
force-pushed
the
support-symfony-6
branch
from
b0cddde to
32aef94
Compare
|
Just checked in local env tests with |
andrew-demb
approved these changes
Jan 22, 2025
|
@andrew-demb I as thinking about release this change as version 7.2.0. WDYT? |
|
I'm OK with minor release here. But I don't see the reason why any change required in the bundle after release here |
|
Actually, you are right 😅 So, what do you suggest? We can merge the current release and tag it? |
|
Yes, it is |
|
Release ready here: Would you please take a look at it, before we release it? |
|
@enricobono I'm ok with current state, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With version 7.0.0 we dropped support for Symfony 6, but the latest versions of the main library graphqlite still support both Symfony 6 and 7.
So, with this PR we reintroduce the support for Symfony 6.