Fix magic call #642
Merged
Fix magic call #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #638
While fixing this I thought it'd probably be better to explicitly mark field getter and setters with an annotation instead of automatically detecting them with
get,setandisprefixes, but maybe just waiting till PHP 8.4 is a better call: by PHP 8.4 we'll hopefully have property accessors so we can drop support for getters/setters/issers and magic__callaltogether.For now, this is just a fix of precedence - now "real" properties always take precedence over
__callcalls.