Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [#708] Re-introduce feature about supporting target method… #709

Conversation

andrew-demb
Copy link
Contributor

… attributes for resolving parameter annotations

Refs: #708

Example use-case: https://github.com/thecodingmachine/graphqlite-symfony-validator-bridge/blob/2f677f6dc5c81660505e6c73952661d4d98f1199/tests/Fixtures/Controllers/UserController.php#L37

If you want to deprecate such behavior - please hint how to deprecate it properly (symfony/deprecation-contracts, doctrine/deprecations, just a comment in the code, etc)

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.21%. Comparing base (53f9d49) to head (8c2bb03).
Report is 97 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #709      +/-   ##
============================================
- Coverage     95.72%   95.21%   -0.52%     
- Complexity     1773     1831      +58     
============================================
  Files           154      174      +20     
  Lines          4586     4953     +367     
============================================
+ Hits           4390     4716     +326     
- Misses          196      237      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

… method attributes for resolving parameter annotations
@andrew-demb
Copy link
Contributor Author

@oojacoboo, please let me know if I need to change anything here

@oojacoboo
Copy link
Collaborator

@andrew-demb please use the @deprecated tag - makes it easily searchable.

@andrew-demb
Copy link
Contributor Author

@oojacoboo but I need to deprecate only using "method target" annotation to be used for parameters.

I don't understand how to deprecate one feature from changed method logic, not all the method.

I will add "trigger_error" with E_USER_DEPRECATED just like in other places in graphqlite

@oojacoboo
Copy link
Collaborator

@andrew-demb That works - yep

@oojacoboo oojacoboo merged commit 04d592f into thecodingmachine:master Nov 26, 2024
9 checks passed
@andrew-demb andrew-demb deleted the parameter-annotations-backward-compatibility branch November 27, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants