Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [#711] Don't reuse cache for differently configured class finder instances #712

Conversation

andrew-demb
Copy link
Contributor

@andrew-demb andrew-demb commented Nov 18, 2024

Context: #711

/cc @oprypkhantc @SCIF

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.19%. Comparing base (53f9d49) to head (94f933a).
Report is 95 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #712      +/-   ##
============================================
- Coverage     95.72%   95.19%   -0.54%     
- Complexity     1773     1826      +53     
============================================
  Files           154      174      +20     
  Lines          4586     4933     +347     
============================================
+ Hits           4390     4696     +306     
- Misses          196      237      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@andrew-demb andrew-demb force-pushed the 711-reuse-class-finder-cache-issues branch from edb14f5 to 94f933a Compare November 18, 2024 22:49
@oprypkhantc
Copy link
Contributor

Makes sense; I thought to add something of the kind, but didn't think there was a real use case for that.

@oojacoboo oojacoboo merged commit 406a0dc into thecodingmachine:master Nov 20, 2024
9 checks passed
@andrew-demb andrew-demb deleted the 711-reuse-class-finder-cache-issues branch November 20, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants