Skip to content

Conversation

@rpluem-vf
Copy link

What changes are you introducing?

Documentation for theforeman/foreman_ansible#749

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • We do not accept PRs for Foreman older than 3.7.

@maximiliankolb maximiliankolb added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Waiting for code Requires merge of related code in another repository before it can be merged labels Jan 27, 2025
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two small comments to align with current style/conventions, rest LGTM. I added the "waiting for code" label.

@maximiliankolb
Copy link
Contributor

triage: PR is still waiting for code in foreman_ansible.

@Lennonka Lennonka added the Waiting on contributor Requires an action from the author label Jul 30, 2025
@maximiliankolb maximiliankolb marked this pull request as draft November 13, 2025 12:53
@maximiliankolb
Copy link
Contributor

triage: converted to draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs style review Requires a review from docs style/grammar perspective Needs tech review Requires a review from the technical perspective Waiting for code Requires merge of related code in another repository before it can be merged Waiting on contributor Requires an action from the author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants