Skip to content

Deprecate old keycloak and redirect all users to new keycloak #3688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 19, 2025
Merged

Deprecate old keycloak and redirect all users to new keycloak #3688

merged 3 commits into from
Mar 19, 2025

Conversation

aneta-petrova
Copy link
Member

What changes are you introducing?

  • Deprecating procedures for the Wildfly distribution of Keycloak (all builds)
  • Including procedures for the Quarkus distribution of Keycloak (Satellite only because they are already included in the other builds)

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Keycloak based on Wildfly itself has been deprecated for a long time.

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

N/A

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.14/Katello 4.16
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • We do not accept PRs for Foreman older than 3.7.

@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Feb 24, 2025
@aneta-petrova aneta-petrova removed the Needs testing Requires functional testing label Feb 24, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 24, 2025 •
edited
Loading

The PR preview for e386b9a is available at theforeman-foreman-documentation-preview-pr-3688.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@aneta-petrova aneta-petrova mentioned this pull request Feb 24, 2025
Open
@aneta-petrova aneta-petrova marked this pull request as ready for review March 18, 2025 14:09
@aneta-petrova
Copy link
Member Author

Hi @maximiliankolb can you please review to make sure this works for upstream and orcharhino?

@aneta-petrova
Copy link
Member Author

Confirmed for Satellite: We can now include the Quarkus Keycloak/Red Hat build of Keycloak setup in downstream. I'll wait for Maximilian's review before setting tech review done.

maximiliankolb
maximiliankolb approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment, overall looks good from my side.

@maximiliankolb maximiliankolb added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Mar 19, 2025
@aneta-petrova aneta-petrova added tech review done No issues from the technical perspective and removed Needs tech review Requires a review from the technical perspective labels Mar 19, 2025
@aneta-petrova aneta-petrova merged commit 623b91c into theforeman:master Mar 19, 2025
9 checks passed
@aneta-petrova aneta-petrova deleted the widlfly-to-quarkus branch March 19, 2025 12:08
@aneta-petrova
Copy link
Member Author

Merged to "master" and cherry-picked:

5f03927..573ece5 3.14 -> 3.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximiliankolb maximiliankolb maximiliankolb approved these changes

Assignees
No one assigned
Labels
style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aneta-petrova @maximiliankolb