Only list required v3_req parameters in openssl.conf #3700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Needs tech review
|
I recall @lpramuk saying that he might be willing to test this :) Can you, Lukáš? Please, let me know what you find out. |
ehelms
reviewed
Mar 12, 2025
guides/common/modules/proc_creating-a-custom-ssl-certificate.adoc
Outdated
Show resolved
Hide resolved
This reverts commit 84fed9d.
aneta-petrova
force-pushed
the
cert_minimum
branch
from
2483670 to
16c62a7
Compare
ehelms
reviewed
Mar 13, 2025
| keyUsage = digitalSignature, nonRepudiation, keyEncipherment, dataEncipherment | ||
| extendedKeyUsage = serverAuth, clientAuth, codeSigning, emailProtection | ||
| keyUsage = digitalSignature, keyEncipherment | ||
| extendedKeyUsage = serverAuth, clientAuth |
There was a problem hiding this comment.
The testing of this uses this configuration which includes some of these (as it was following the docs): https://github.com/SatelliteQE/robottelo/blob/7306155b578f1f574f7ad07060b09fdfaa8d9e3f/tests/foreman/data/openssl.cnf#L60-L61
We should update that to match this.
|
@lpramuk might be able to test next week. |
|
@lpramuk and/or @ehelms, does SatelliteQE/robottelo#17987 mean that we can merge this doc PR as well? |
ekohl
approved these changes
Apr 10, 2025
aneta-petrova
added
tech review done
|
Dear writers, anyone up for a style review? |
maximiliankolb
added
style review done
aneta-petrova
added a commit
that referenced
this pull request
Apr 11, 2025
(cherry picked from commit c5ad188)
aneta-petrova
added a commit
that referenced
this pull request
Apr 11, 2025
(cherry picked from commit c5ad188)
aneta-petrova
added a commit
that referenced
this pull request
Apr 11, 2025
(cherry picked from commit c5ad188)
aneta-petrova
added a commit
that referenced
this pull request
Apr 11, 2025
(cherry picked from commit c5ad188)
aneta-petrova
added a commit
that referenced
this pull request
Apr 11, 2025
(cherry picked from commit c5ad188)
aneta-petrova
added a commit
that referenced
this pull request
Apr 11, 2025
(cherry picked from commit c5ad188)
aneta-petrova
added a commit
that referenced
this pull request
Apr 11, 2025
(cherry picked from commit c5ad188)
aneta-petrova
added a commit
that referenced
this pull request
Apr 11, 2025
(cherry picked from commit c5ad188)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Removing selected [v3_req] parameters from example openssl.cnf.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
The current list includes parameters that are not strictly necessary. https://issues.redhat.com/browse/SAT-31112
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
N/A
Checklists
Please cherry-pick my commits into: