Drop all oVirt/RHV #3800
Open
Drop all oVirt/RHV #3800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Needs tech review
Lennonka
added
the
Waiting for code
|
For upstream and downstream orcharhino, this is OK if we merge it to "master" after branching 3.15. |
Co-authored-by: Maximilian Kolb <[email protected]>
|
@stejskalleos Tech ack, please. |
maximiliankolb
approved these changes
Apr 28, 2025
maximiliankolb
added
style review done
|
Since this is a removal, I don't think it will need testing. Tech ack should suffice. |
stejskalleos
suggested changes
Apr 29, 2025
There was a problem hiding this comment.
Some files that should be updated / removed as well:
guides/common/modules/ref_troubleshooting-virt-who.adocguides/common/modules/snip_steps-create-a-host-tab-interfaces.adocguides/common/modules/proc_searching-for-hosts-with-a-specific-fact-value.adocguides/common/modules/proc_adding-images-to-server.adoc
pr-processor
bot
added
the
Waiting on contributor
pr-processor
bot
added
Needs re-review
and removed
Waiting on contributor
|
@stejskalleos @maximiliankolb Can you, please, re-review the latest commit? |
stejskalleos
approved these changes
Apr 30, 2025
There was a problem hiding this comment.
🍏 LGTM
The linkchecker is failing on the https://www.gnu.org/software/grub/manual/grub/grub.html#Shell_002dlike-scripting URL, but I tried it and it's working.
maximiliankolb
added
tech review done
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Dropping oVirt compute resource provider, all oVirt mentions and attributes
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
oVirt integration is going to be deprecated in 3.15 and removed in 3.16
https://community.theforeman.org/t/rfc-deprecation-and-removal-of-ovirt-compute-resource/42527
https://projects.theforeman.org/issues/38266
https://issues.redhat.com/browse/SAT-12005
Related to #3724
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Checklists
Please cherry-pick my commits into: N/A