Skip to content

Add custom provisioning snippet for SLES #3802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

Add custom provisioning snippet for SLES #3802

merged 1 commit into from
Jul 1, 2025

Conversation

maximiliankolb
Copy link
Contributor

@maximiliankolb maximiliankolb commented Apr 24, 2025 •
edited
Loading

What changes are you introducing?

Add new example for custom provisioning snippets for SUSE family

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

We only had examples for Debian and EL.

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

I have tested the installation command in a container.

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.14/Katello 4.16
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9; orcharhino 7.1 with Leapp)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • We do not accept PRs for Foreman older than 3.7.

@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Apr 24, 2025
@github-actions GitHub Actions
Copy link

The PR preview for ca2d4bb is available at theforeman-foreman-documentation-preview-pr-3802.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@maximiliankolb maximiliankolb removed Not yet reviewed Needs testing Requires functional testing labels Apr 24, 2025
Lennonka
Lennonka approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style-wise LGTM.

However, I'm not sure if it adds any value for the user when it's almost the same as the example for EL. Not blocking it, though.

@aneta-petrova aneta-petrova added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels May 13, 2025
goarsna
goarsna approved these changes Jul 1, 2025
View reviewed changes
Copy link
Contributor

@goarsna goarsna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a technical POV. Thanks, Maximilian!

@maximiliankolb maximiliankolb added tech review done No issues from the technical perspective and removed Needs tech review Requires a review from the technical perspective labels Jul 1, 2025
@maximiliankolb maximiliankolb merged commit 84b4e87 into theforeman:master Jul 1, 2025
10 of 11 checks passed
@maximiliankolb maximiliankolb deleted the autoyast_provisioning_snippet branch July 1, 2025 07:56
maximiliankolb added a commit that referenced this pull request Jul 1, 2025
@maximiliankolb
Add custom provisioning snippet for SLES (#3802)
d934540 
(cherry picked from commit 84b4e87)
maximiliankolb added a commit that referenced this pull request Jul 1, 2025
@maximiliankolb
Add custom provisioning snippet for SLES (#3802)
83633ca 
(cherry picked from commit 84b4e87)
@maximiliankolb
Copy link
Contributor Author

Merged to "master" and cherry-picked:
9f2ae90..d934540 3.15 -> 3.15
3447904..83633ca 3.14 -> 3.14

jherrman added a commit to jherrman/foreman-documentation that referenced this pull request Jul 3, 2025
@jherrman
Sync branch with master - take 2
1e15dee 
Squashed commit of the following:

commit 3ac8d30
Author: Aneta Šteflová Petrová <[email protected]>
Date:   Wed Jul 2 16:09:35 2025 +0200

    Fix placement of Insights advisor docs (theforeman#3910)

    ---------

    Co-authored-by: Maximilian Kolb <[email protected]>

commit e4baa4c
Author: Maximilian Kolb <[email protected]>
Date:   Wed Jul 2 16:07:58 2025 +0200

    Do not use assembly within another assembly (theforeman#3963)

commit ee9ce56
Author: Lena Ansorgová <[email protected]>
Date:   Tue Jul 1 13:10:20 2025 +0200

    Add EL 9 to EL 10 Leapp host upgrade (theforeman#3461)

commit d8ed823
Author: Avital Pinnick <[email protected]>
Date:   Mon Jun 30 17:29:14 2025 +0300

    Add mod doc type attribute to script

commit b46a328
Author: Maximilian Kolb <[email protected]>
Date:   Tue Jul 1 12:51:18 2025 +0200

    Bump orcharhino version to 7.3 (theforeman#3970)

    orcharhino 7.3 is based on Foreman 3.12 and runs on EL9 only.

    Refs https://orcharhino.com/en/ressourcen/release-notes/orcharhino-7-3/

commit 26ec914
Author: Aneta Šteflová Petrová <[email protected]>
Date:   Tue Jul 1 11:24:43 2025 +0200

    Add review checklists to PR template (theforeman#3946)

    * Add review checklists to PR template
    * Drop explanation of tech review and style review from contribution guidelines

commit 464aba9
Author: Maximilian Kolb <[email protected]>
Date:   Tue Jul 1 10:55:08 2025 +0200

    Allow attributes in code blocks (theforeman#3965)

commit 84b4e87
Author: Maximilian Kolb <[email protected]>
Date:   Tue Jul 1 09:56:31 2025 +0200

    Add custom provisioning snippet for SLES (theforeman#3802)

commit ee37140
Author: Jiri Herrmann <[email protected]>
Date:   Mon Jun 30 11:07:13 2025 +0200

    Updating information on local testing in the README (theforeman#3772)

    ---------

    Co-authored-by: Aneta Šteflová Petrová <[email protected]>

commit 544f6fe
Author: Lena Ansorgová <[email protected]>
Date:   Thu Jun 26 15:33:56 2025 +0200

    Update navigation for Insights (theforeman#3960)

commit a3e1245
Author: Avital Pinnick <[email protected]>
Date:   Thu Jun 26 15:11:48 2025 +0300

    Add assembly attribute (theforeman#3950)

    * Adding content tag to assemblies
    * hammer script

commit 16ad1cc
Author: Ewoud Kohl van Wijngaarden <[email protected]>
Date:   Thu Jun 26 14:04:14 2025 +0200

    Drop mentions of --foreman-proxy-register-in-foreman (theforeman#3080)

    * Drop mentions of --foreman-proxy-register-in-foreman

    By removing mentions of this, it becomes an unsupported feature. This is
    good because various parts of the documentation assume it's turned on.
    Users can easily get into unexpected errors way further down the line if
    they disable this feature.

    Where there were explicit instructions to disable it, the text is
    changed into troubleshooting.

    * Rewrite networking ports to prerequisite

commit 55a4430
Author: Maximilian Kolb <[email protected]>
Date:   Wed Jun 25 15:56:52 2025 +0200

    Fix Salt Minion setup (theforeman#3957)

    * Add procedure to configure Salt on hosts
    * Extend Salt Autosign setup
    Refs https://github.com/ATIX-AG/foreman_salt/blob/675ba7dd6bd7730465e11518c8ddc3f450f022e6/app/views/foreman_salt/salt_autosign/index.html.erb#L3
    * Document required ports on Salt master
    Refs https://docs.saltproject.io/en/latest/topics/tutorials/firewall.html
    * Fix file prefix
    * Use proper attribute for SmartProxyServer

commit 8b1b052
Author: Lena Ansorgová <[email protected]>
Date:   Tue Jun 24 18:55:05 2025 +0200

    Add diagram of installer-based provisioning with full-host bootdisk (theforeman#3308)

commit 42be2ed
Author: Zuzana Lena Ansorgova <[email protected]>
Date:   Thu Jun 19 18:19:10 2025 +0200

    Fix Azure image gallery path

commit abe7299
Author: Aneta Šteflová Petrová <[email protected]>
Date:   Tue Jun 24 13:15:32 2025 +0200

    Simplify upgrade backup step (theforeman#3945)

    * Simplify upgrade backup step

    ---------

    Co-authored-by: Maximilian Kolb <[email protected]>

commit fd2c753
Author: Zuzana Lena Ansorgova <[email protected]>
Date:   Tue Jun 17 22:02:54 2025 +0200

    Improve provision permissions

commit 6c53244
Author: Zuzana Lena Ansorgova <[email protected]>
Date:   Tue Jun 17 21:58:45 2025 +0200

    Replace procedure with warning

commit 38ad314
Author: Maximilian Kolb <[email protected]>
Date:   Mon Jun 23 16:14:43 2025 +0200

    Use upstream term in file name (theforeman#3924)

    Refs PR 3894 on GitHub

commit 6d53e2d
Author: Maximilian Kolb <[email protected]>
Date:   Mon Jun 23 15:58:12 2025 +0200

    Fix command to upload Salt reports (theforeman#3935)

    The command depends on Python which
    in turn depends on a Salt version

commit a5c1bf8
Author: Ewoud Kohl van Wijngaarden <[email protected]>
Date:   Mon Jun 23 10:08:16 2025 +0200

    Bring back the Puma workers and threads recommendations (theforeman#3942)

    * Bring back the Puma workers and threads recommendations

    This reverts commit b3491af and instead
    brings back the inclusion.

    * Use many instead of lots of

commit 88072ab
Author: Lena Ansorgová <[email protected]>
Date:   Thu Jun 19 18:45:19 2025 +0200

    Restructure boot disks in provisioning (theforeman#3625)

    Co-authored-by: Maximilian Kolb <[email protected]>

commit bc888f4
Author: Brian Angelica <[email protected]>
Date:   Thu Jun 19 01:27:01 2025 -0400

    Drop "minimal" from a parameter description (theforeman#3944)

    The parameter is not related to the minimal/optional setting.

commit 71a2fd8
Author: Brian Angelica <[email protected]>
Date:   Wed Jun 18 13:21:07 2025 -0400

    Add new parameter to reference module (theforeman#3913)

commit 50080bf
Author: Aneta Šteflová Petrová <[email protected]>
Date:   Wed Jun 18 15:29:22 2025 +0200

    Improve proxy upgrade procedure (theforeman#3885)

    * Simplify syncing new repos and proxy upgrade
    * Include proxy upgrade procedure for Debian
    * Replace REX proxy upgrade procedure with a reference to the job template
    * Drop step to clean metadata
    * Drop step to verify that settings.yml points to FQDN
    * Minor edits

    ---------

    Co-authored-by: Maximilian Kolb <[email protected]>

commit 23e157c
Author: Aneta Šteflová Petrová <[email protected]>
Date:   Wed Jun 18 11:17:26 2025 +0200

    Improve section on post-upgrade tasks (theforeman#3907)

    * Review post-upgrade tasks
    * Remove post-upgrade task to migrate container manifest data
    * Merge post-upgrade tasks into upgrading
    * Turn post-upgrade tasks into a snippet

    ---------

    Co-authored-by: Maximilian Kolb <[email protected]>
apinnick pushed a commit to apinnick/foreman-documentation that referenced this pull request Jul 6, 2025
@maximiliankolb @apinnick
Add custom provisioning snippet for SLES (theforeman#3802)
b9e62b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lennonka Lennonka Lennonka approved these changes

@goarsna goarsna goarsna approved these changes

Assignees
No one assigned
Labels
style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maximiliankolb @Lennonka @goarsna @aneta-petrova