Skip to content

Use table for default OS repositories #3804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maximiliankolb
Copy link
Contributor

What changes are you introducing?

Introduce tables to list default OS repositories of supported Client OS

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

to simplify and shorten instructions

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.14/Katello 4.16
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9; orcharhino 7.1 with Leapp)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • We do not accept PRs for Foreman older than 3.7.

@maximiliankolb maximiliankolb added the Needs style review Requires a review from docs style/grammar perspective label Apr 24, 2025
@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs testing Requires functional testing labels Apr 24, 2025
@maximiliankolb
Copy link
Contributor Author

@sbernhard What do you think about this structure/these tables?

Copy link

@ekohl
Copy link
Member

ekohl commented Apr 24, 2025

@maximiliankolb if you want inspiration on how to make the application better: Foreman already has a list of operating systems and related media. Those are the same URLs as you're documenting here. What engineering wise could be built is an extension to Katello to build a wizard to set up content sources for an existing OS.

So it roughly becomes:

  • Select an OS. For example, by going to the OS overview and select the "Set up content syncing"
  • Add installation media. By default it will select the ones that are already added for that OS, but users can select any

Then to make it nicer we can add any repos we're missing to db/seeds.d/100-installation_media.rb.

That way you don't need to maintain a large table that users need to copy and have a nicer user experience. There would be consistency between provisioning with and without Katello by using the same data.

@maximiliankolb
Copy link
Contributor Author

@sbernhard What do you think about this structure/these tables? I still think they are too bloated but an improvement to the status quo. What do you think about Ewoud's suggestion to move this to DB seeds?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs style review Requires a review from docs style/grammar perspective Needs tech review Requires a review from the technical perspective Needs testing Requires functional testing Not yet reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants