Skip to content

Move default OS repositories to tables#3804

Merged
maximiliankolb merged 1 commit intotheforeman:masterfrom
ATIX-AG:use_table_for_default_os_content
Jul 21, 2025
Merged

Move default OS repositories to tables#3804
maximiliankolb merged 1 commit intotheforeman:masterfrom
ATIX-AG:use_table_for_default_os_content

Conversation

@maximiliankolb
Copy link
Contributor

@maximiliankolb maximiliankolb commented Apr 24, 2025 •
edited
Loading

What changes are you introducing?

Introduce tables to list default OS repositories of supported Client OS

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

to simplify and shorten instructions

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9; orcharhino 7.1 with Leapp)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • We do not accept PRs for Foreman older than 3.7.

@maximiliankolb maximiliankolb added the Needs style review Requires a review from docs style/grammar perspective label Apr 24, 2025
@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs testing Requires functional testing labels Apr 24, 2025
@maximiliankolb
Copy link
Contributor Author

maximiliankolb commented Apr 24, 2025

@sbernhard What do you think about this structure/these tables?

@github-actions
Copy link

github-actions bot commented Apr 24, 2025 •
edited
Loading

The PR preview for c5c9eec is available at theforeman-foreman-documentation-preview-pr-3804.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@ekohl
Copy link
Member

ekohl commented Apr 24, 2025

@maximiliankolb if you want inspiration on how to make the application better: Foreman already has a list of operating systems and related media. Those are the same URLs as you're documenting here. What engineering wise could be built is an extension to Katello to build a wizard to set up content sources for an existing OS.

So it roughly becomes:

  • Select an OS. For example, by going to the OS overview and select the "Set up content syncing"
  • Add installation media. By default it will select the ones that are already added for that OS, but users can select any

Then to make it nicer we can add any repos we're missing to db/seeds.d/100-installation_media.rb.

That way you don't need to maintain a large table that users need to copy and have a nicer user experience. There would be consistency between provisioning with and without Katello by using the same data.

@maximiliankolb maximiliankolb mentioned this pull request May 2, 2025
Closed
2 tasks
@maximiliankolb
Copy link
Contributor Author

maximiliankolb commented May 2, 2025

@sbernhard What do you think about this structure/these tables? I still think they are too bloated but an improvement to the status quo. What do you think about Ewoud's suggestion to move this to DB seeds?

@maximiliankolb maximiliankolb mentioned this pull request Jul 18, 2025
Open
@maximiliankolb
Copy link
Contributor Author

maximiliankolb commented Jul 21, 2025

@sbernhard What do you think about these tables? ACK to move forward with this or do you want us/upstream to go another direction?

sbernhard
sbernhard approved these changes Jul 21, 2025
View reviewed changes
Copy link
Contributor

@sbernhard sbernhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its better to have this table than what we have currently. Thanks.
(best would be to have the automated way as Ewoud said - but this is something even greater)

@maximiliankolb
Move default OS repositories to tables
c5c9eec 
This patch consolidates all default OS repositories for supported
Clients. The reference file contains tables for all supported Deb and EL
Clients from yum.theforeman.org and oss.atix.de.
@maximiliankolb maximiliankolb force-pushed the use_table_for_default_os_content branch from 5784f72 to c5c9eec Compare July 21, 2025 11:31
@maximiliankolb maximiliankolb changed the title Use table for default OS repositories Move default OS repositories to tables Jul 21, 2025
@maximiliankolb maximiliankolb linked an issue Jul 21, 2025 that may be closed by this pull request
Preparing client platforms #4019
Open
@maximiliankolb maximiliankolb added tech review done No issues from the technical perspective and removed Needs tech review Requires a review from the technical perspective Needs testing Requires functional testing labels Jul 21, 2025
@maximiliankolb maximiliankolb marked this pull request as ready for review July 21, 2025 11:34
@maximiliankolb maximiliankolb requested a review from Lennonka July 21, 2025 11:35
Lennonka
Lennonka approved these changes Jul 21, 2025
View reviewed changes
Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

However, this shouldn't close #4019. That issue relates to operating systems not repositories.

@Lennonka Lennonka removed a link to an issue Jul 21, 2025
Preparing client platforms #4019
Open
@maximiliankolb maximiliankolb added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Jul 21, 2025
@maximiliankolb maximiliankolb merged commit 29eda6f into theforeman:master Jul 21, 2025
10 checks passed
@maximiliankolb maximiliankolb deleted the use_table_for_default_os_content branch July 21, 2025 13:50
maximiliankolb added a commit that referenced this pull request Jul 21, 2025
@maximiliankolb
Move default OS repositories to tables (#3804)
ae2ced8 
This patch consolidates all default OS repositories for supported
Clients. The reference file contains tables for all supported Deb and EL
Clients from yum.theforeman.org and oss.atix.de.

(cherry picked from commit 29eda6f)

Resolved a minor merge conflict in
"guides/common/modules/proc_adding-custom-rpm-repositories-el.adoc" and
"guides/common/modules/proc_adding-upstream-repositories-for-deb.adoc"
by dropping those changes.

Also removed the "REFERENCE" attribute in the first line of
"guides/common/modules/ref_default-operating-system-repositories.adoc"
because we do not backport these attributes for 3.15.
maximiliankolb added a commit that referenced this pull request Jul 21, 2025
@maximiliankolb
Move default OS repositories to tables (#3804)
34dbe7e 
This patch consolidates all default OS repositories for supported
Clients. The reference file contains tables for all supported Deb and EL
Clients from yum.theforeman.org and oss.atix.de.

(cherry picked from commit 29eda6f)

Resolved a minor merge conflict in
"guides/common/modules/proc_adding-custom-rpm-repositories-el.adoc" and
"guides/common/modules/proc_adding-upstream-repositories-for-deb.adoc"
by dropping those changes.

Also removed the "REFERENCE" attribute in the first line of
"guides/common/modules/ref_default-operating-system-repositories.adoc"
because we do not backport these attributes for 3.15.

(cherry picked from commit ae2ced8)
@maximiliankolb
Copy link
Contributor Author

maximiliankolb commented Jul 21, 2025

Merged to "master" and cherry-picked:
5d201d4..ae2ced8 3.15 -> 3.15
3f05e52..34dbe7e 3.14 -> 3.14

@maximiliankolb maximiliankolb mentioned this pull request Jul 22, 2025
Merged
16 tasks
apinnick pushed a commit to apinnick/foreman-documentation that referenced this pull request Jul 22, 2025
@maximiliankolb @apinnick
Move default OS repositories to tables (theforeman#3804)
65fe92e 
This patch consolidates all default OS repositories for supported
Clients. The reference file contains tables for all supported Deb and EL
Clients from yum.theforeman.org and oss.atix.de.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lennonka Lennonka Lennonka approved these changes

+1 more reviewer

@sbernhard sbernhard sbernhard approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maximiliankolb @ekohl @Lennonka @sbernhard