Remove instructions to place GCE key in /etc/foreman #3841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hammer uploads the key to Foreman (just like in the UI procedure) and never read again. This means there's no point in storing the file in /etc/foreman with specific permissions. Fixes: 40b1180 ("Remake GCE for Foreman Google plugin")
github-actions
bot
added
Needs tech review
|
The PR preview for 7259b30 is available at theforeman-foreman-documentation-preview-pr-3841.surge.sh The following output files are affected by this PR: |
|
One instance of "GCE_KEY" in the rendered docs is not italic: You might need double underscores. @ekohl |
|
@maximiliankolb did you have a look at my thoughts on whether we need the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Remove the instructions to place the key in
/etc/foreman.Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Hammer uploads the key to Foreman (just like in the UI procedure) and never read again. This means there's no point in storing the file in /etc/foreman with specific permissions.
It was introduced in 40b1180 (#1949).
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
I changed the Hammer command to run as root for two reasons: the scp command also uses root and the installer sets up Hammer for root by default. 1137d3a changed it to non-root and this goes against that.
An alternative is to change the instruction to a prerequisite to have Hammer set up and the key file present. Then you only need to list the Hammer command.
Checklists
Please cherry-pick my commits into: