-
Notifications
You must be signed in to change notification settings - Fork 100
Document new usage metrics timer #3973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Document new usage metrics timer #3973
Conversation
The PR preview for 0cd6b2e is available at theforeman-foreman-documentation-preview-pr-3973.surge.sh The following output files are affected by this PR: |
Hi @adamruzicka and @pondrejk , can you please review? |
guides/common/modules/con_overview-of-usage-metrics-collection-in-project.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/con_overview-of-usage-metrics-collection-in-project.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/con_overview-of-usage-metrics-collection-in-project.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_disabling-the-collection-of-usage-metrics.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_disabling-the-collection-of-usage-metrics.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_disabling-the-collection-of-usage-metrics.adoc
Show resolved
Hide resolved
guides/common/modules/proc_reviewing-usage-metrics-collected-from-your-project.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Adam Růžička <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment, rest LGTM style wise.
guides/common/modules/proc_disabling-the-collection-of-usage-metrics.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style-wise LGTM
What changes are you introducing?
Adding information about a new timer that collects usage metrics from Satellite.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
theforeman/foreman_maintain#996
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Contributor checklists
Please cherry-pick my commits into:
Review checklists
Tech review (performed by an Engineer who did not author the PR; can be skipped if tech review is unnecessary):
Style review (by a Technical Writer who did not author the PR):