Remove unused NPM modules#4151
Merged
ehelms merged 2 commits intotheforeman:rpm/developfrom Oct 2, 2019
Merged
Conversation
2c2c7b9 to
f4d2230
Compare
Member
Author
|
Also, these updates are based on theforeman/npm2rpm#58 |
aaab038 to
571f9a7
Compare
Member
Author
|
This now only represents about half the modules in an attempt to get it through CI. |
cd86ca2 to
325693a
Compare
Member
Author
|
[test rpm] |
325693a to
ebc8ce6
Compare
Member
Author
|
[test rpm] |
ebc8ce6 to
280f1eb
Compare
Member
Author
|
This PR is now focused on removing unused NPM modules. This took a tactical approach to identify unused modules by analyzing Requires within all spec files. The scripts I used: |
ekohl
approved these changes
Oct 2, 2019
Member
ekohl
left a comment
There was a problem hiding this comment.
I had considered storing the strategy somewhere. Is there already code that uses this?
package_manifest.yaml
Outdated
| strategy: bundle | ||
| nodejs-babel-plugin-lodash: | ||
| strategy: bundle | ||
| #nodejs-babel-plugin-syntax-dynamic-import: {} |
280f1eb to
a4e4dab
Compare
Member
Author
|
The work I started in Obal to add an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a large PR as there are a large number of nodejs modules. This updates just the Foreman modules for now to a spec that can support building for the SCL. These changes come with some updated bundle tarballs, and updated dependencies for those bundles. This also removes two packages that were not required by any existing spec: nodejs-select2 and nodejs-jquery-flot. I didn't feel like making 150+ PRs for each package. So my hope is if this succeeds we feel confident enough to merge and fix up any issues after.