Skip to content

build commits into @theforeman/develop copr #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Jul 24, 2025

What are the changes introduced in this pull request?

instead of building to packit/theforeman-foreman_rh_cloud-develop this builds into @theforeman/develop so that all plugins can have a central "nightly" place

Considerations taken when implementing this change?

What are the testing steps for this pull request?

Can't be tested before merging.

https://packit.dev/docs/configuration/upstream/copr_build#using-a-custom-copr-project was followed

Summary by Sourcery

Build:

  • Configure Copr owner as '@theforeman' and project as 'develop' in .packit.yaml

Copy link

sourcery-ai bot commented Jul 24, 2025

Reviewer's Guide

Update .packit.yaml to redirect Copr builds for the develop branch into a centralized @theforeman/develop project by adding the appropriate owner and project settings.

File-Level Changes

Change Details Files
Configure packit to build into a shared @theforeman/develop Copr project
  • Add owner field set to '@theforeman'
  • Add project field set to 'develop'
.packit.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @evgeni - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@evgeni
Copy link
Member Author

evgeni commented Jul 24, 2025

@ehelms @ares this should lay the groundwork for the centralized "plugins nightly copr" we talked about

@evgeni
Copy link
Member Author

evgeni commented Jul 24, 2025

Until fedora-copr/copr#3804 is implemented, each git repo needs to be added to copr manually :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants