Release 10.0.7 #1051
Open
Release 10.0.7 #1051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do the following: * Create methods to validate user input, and push token collection into the "input collection" section of the rake task. This lets the "data preparation" section of the script be more focused. * Drop duplicate comments from the error handling block, for legibility. * Print the default registration URL. This helps the user understand what the script is doing, and gives an example in the case where a user would like to provide a custom URL. * Optionally prepend a scheme to a user-provided URL. That is, example.com will be transformed to https://example.com. * Do not append a path to a user-provided custom URL. This ensures forward compatibility in the case that Insights requires registration at a new path (e.g. /api/identityv2/certificate/registrations). (cherry picked from commit 914d2fb)
|
@evgeni do you know why this is failing? |
|
[test] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.