-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring/fairspc 82 #1566
Open
tgreenwood
wants to merge
82
commits into
dev
Choose a base branch
from
refactoring/FAIRSPC-82
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactoring/fairspc 82 #1566
Changes from 36 commits
Commits
Show all changes
82 commits
Select commit
Hold shift + click to select a range
f194327
FAIRSPC-82: started switching to Spring Boot
tgreenwood 5147398
FAIRSPC-82: started switching to Spring Boot
tgreenwood f96bc0a
Merge remote-tracking branch 'origin/refactoring/FAIRSPC-82' into ref…
tgreenwood 8e1ee28
FAIRSPC-82: config loader
tgreenwood 22e00fb
FAIRSPC-82: updated security config
tgreenwood 0d9d964
FAIRSPC-82: fixed webdav endpoints
tgreenwood 923bfc1
FAIRSPC-82: fixed user service and security config
tgreenwood 34620c5
FAIRSPC-82: fixed security issue in async processes
tgreenwood 322325a
FAIRSPC-82: fixed webdav endpoints
tgreenwood f3564b3
FAIRSPC-82: added SPARQL query read-only endpoint
tgreenwood 9fa7093
FAIRSPC-82: slightly cleaned up the code, removed obsoleted todo's
tgreenwood 84d0914
FAIRSPC-82: added permission check for the sparql query
tgreenwood 3b3a2c8
FAIRSPC-82: added features config and condition to switch it on/off
tgreenwood b8e8bb8
FAIRSPC-82: moved part of configs to properties files
tgreenwood fc0d25e
FAIRSPC-82: switched cache config to spring properties
tgreenwood 88052d8
FAIRSPC-82:
tgreenwood 2dd43ad
FAIRSPC-82: moved public url to application.yml
tgreenwood e50b5b0
FAIRSPC-82: moved webdav to application.yml
tgreenwood 66d5476
FAIRSPC-82: moved auth config to keycloak properties
tgreenwood 3363eb0
FAIRSPC-82: removed old-fashion readiness and health endpoints; added…
tgreenwood 75c87b3
FAIRSPC-82: fixed pluto health check of saturn
tgreenwood 96c501e
FAIRSPC-82: got rid of config file amd moved to application.yaml
tgreenwood 8d113f4
Merge branch 'dev' into refactoring/FAIRSPC-82
tgreenwood 77b247a
FAIRSPC-82: applied spotless rules + warnings resolve
tgreenwood 2d0f542
FAIRSPC-82: fixed some tests + refactoring
tgreenwood 9dbe166
FAIRSPC-82: fixed some tests
tgreenwood f2889a7
FAIRSPC-82: fixed UserService tests
tgreenwood 6590c66
FAIRSPC-82: fixed a bunch of tests
tgreenwood 164c986
FAIRSPC-82: upgraded version of jena
tgreenwood 0710bb3
FAIRSPC-82: fixed some tests
tgreenwood 5f76dd4
FAIRSPC-82: fixed the remaining failing tests
tgreenwood 718c152
FAIRSPC-82: cleaned up warnings
tgreenwood 009acc2
FAIRSPC-82: cleaned up warnings
tgreenwood c951859
FAIRSPC-82: removed redundant ttl files
tgreenwood 1e72d47
FAIRSPC-82 removed accidentally added yarn command
tgreenwood 0c9043a
Update README.adoc
tgreenwood 29adbdb
FAIRSPC-81: migrated views endpoint to spring mvc
tgreenwood d3f11cd
FAIRSPC-81: migrated workspace endpoints to spring mvc
tgreenwood 51b3ce9
FAIRSPC-81: refactoring of controller tests
tgreenwood ea2e4d6
FAIRSPC-81: migrated metadata API to spring mvc
tgreenwood e070d9d
FAIRSPC-81: migrated vocabulary API to spring mvc
tgreenwood 0e2a77b
FAIRSPC-81: migrated features endpoint to spring mvc
tgreenwood 1351e93
FAIRSPC-81: migrated maintain endpoint to spring mvc
tgreenwood e344891
FAIRSPC-81: migrated user endpoints to spring mvc
tgreenwood 1500c8a
FAIRSPC-82: fixed typo
tgreenwood 766f84b
FAIRSPC-82: rollback of accidentally commited change in security config
tgreenwood 86203c3
FAIRSPC-82: fixed health endpoints
tgreenwood d96b8c9
FAIRSPC-82: added timeout to sparql endpoint
tgreenwood 7c8bbd0
Merge branch 'refactoring/FAIRSPC-82' into refactoring/FAIRSPC-81
tgreenwood b81b005
FAIRSPC-82: migrated search endpoints to spring mvc
tgreenwood b480ae7
FAIRSPC-82: removed redundant logout from Saturn as logging out happe…
tgreenwood e53bc8e
Merge branch 'refactoring/FAIRSPC-82' into refactoring/FAIRSPC-81
tgreenwood 17e7514
FAIRSPC-81: got rid of java-spark framework and Jetty
tgreenwood 921ade7
FAIRSPC-81: tuned global exception handling
tgreenwood c8217f6
FAIRSPC-82: fixed liveness and readiness probes of Saturn in helm charts
tgreenwood 41d5807
FAIRSPC-82: got rid of PermissionService
tgreenwood 8f85b5f
FAIRSPC-82: removed unused method and rolled back accidentally commit…
tgreenwood d4c338b
Merge branch 'refactoring/FAIRSPC-82' into refactoring/FAIRSPC-81
tgreenwood 62eb244
FAIRSPC-79: partially refactored code with some services marked as bean
tgreenwood a1fbee9
FAIRSPC-79: migrated all web DAV instantiation under Spring's control
tgreenwood ac7b6e4
FAIRSPC-81: aligned all controllers with /api/ path
tgreenwood b18d47a
FAIRSPC-81: named reasonable get view data
tgreenwood c35bae3
FAIRSPC-81: removed redundant try-catch
tgreenwood a0c37d1
FAIRSPC-81: aligned the way we map resources across all controllers
tgreenwood 001022e
FAIRSPC-81: removed mentioning of spark on log config
tgreenwood 91ef6af
FAIRSPC-81: replaced two value classes with records
tgreenwood 8397e6f
Merge branch 'refactoring/FAIRSPC-81' into refactoring/FAIRSPC-79
tgreenwood fc40d62
FAIRSPC-81: set servlet context path to /api
tgreenwood 3ce8b8b
Merge branch 'refactoring/FAIRSPC-81' into refactoring/FAIRSPC-79
tgreenwood f8d27ea
FAIRSPC-81: got rid of Service.java (first iteration)
tgreenwood 59e870e
Merge pull request #1567 from thehyve/refactoring/FAIRSPC-81
tgreenwood 0d93e23
FAIRSPC-79: made configs more granular and other changes towards IoC …
tgreenwood dd99457
FAIRSPC-79: got rid of redundant qualifier annotations
tgreenwood 9fd8994
FAIRSPC-79: migrated vocabularies from static context to IoC managed
tgreenwood 00ccac3
FAIRSPC-79: migrated validators to spring initialisation
tgreenwood 5725884
FAIRSPC-79: light refactoring + important todo
tgreenwood 9a2890f
FAIRSPC-79: fixed all tests after migration
tgreenwood bd77df5
FAIRSPC-79: removed redundant init block in tests
tgreenwood c36d3a1
FAIRSPC-79: changed default transaction simple to bulk
tgreenwood 9d07d42
FAIRSPC-79: removed dependency of URI validator from DavFactory
tgreenwood 56e4d30
FAIRSPC-79: updated todos
tgreenwood 19e7e18
Merge pull request #1568 from thehyve/refactoring/FAIRSPC-79
tgreenwood File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69 changes: 0 additions & 69 deletions
69
projects/saturn/src/main/java/io/fairspace/saturn/App.java
This file was deleted.
Oops, something went wrong.
12 changes: 12 additions & 0 deletions
12
projects/saturn/src/main/java/io/fairspace/saturn/SaturnApplication.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
package io.fairspace.saturn; | ||
|
||
import org.springframework.boot.SpringApplication; | ||
import org.springframework.boot.autoconfigure.SpringBootApplication; | ||
|
||
@SpringBootApplication | ||
public class SaturnApplication { | ||
|
||
public static void main(String[] args) { | ||
SpringApplication.run(SaturnApplication.class, args); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
projects/saturn/src/main/java/io/fairspace/saturn/auth/CustomAuthenticationEntryPoint.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
package io.fairspace.saturn.auth; | ||
|
||
import java.io.IOException; | ||
|
||
import jakarta.servlet.http.HttpServletRequest; | ||
import jakarta.servlet.http.HttpServletResponse; | ||
import org.springframework.security.core.AuthenticationException; | ||
import org.springframework.security.web.AuthenticationEntryPoint; | ||
import org.springframework.stereotype.Component; | ||
|
||
@Component | ||
public class CustomAuthenticationEntryPoint implements AuthenticationEntryPoint { | ||
|
||
public static final String LOGIN_PATH = "/login"; | ||
|
||
@Override | ||
public void commence( | ||
HttpServletRequest request, HttpServletResponse response, AuthenticationException authException) | ||
throws IOException { | ||
if (request.getRequestURI().startsWith("/api/")) { | ||
response.setStatus(HttpServletResponse.SC_UNAUTHORIZED); | ||
if (request.getCookies() == null || request.getCookies().length == 0) { | ||
response.addHeader("WWW-Authenticate", "Basic"); | ||
} | ||
} else { | ||
response.sendRedirect(LOGIN_PATH); | ||
} | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is it not needed anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
log4j-slf4j2-impl is not used, all the rest come with other dependencies
by the way, I noticed you use several different log providers in Saturn (slf4j, lo4j, log4j2) - I will create ticket to align it across Saturn