-
Notifications
You must be signed in to change notification settings - Fork 10
Add predict kwargs in validation step #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If tests are necessary, should they be added in test_cellflow or in test_trainer? |
Codecov ReportAttention: Patch coverage is
❌ Your project status has failed because the head coverage (0.00%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #228 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 38 38
Lines 2723 2727 +4
=====================================
- Misses 2723 2727 +4
🚀 New features to boost your workflow:
|
Let's please add a test checking for passing the number of steps of the solver, and make sure if it's 2 steps it's considerablyu faster (e.g. 1 sec) than passing 1e7 steps. Let's add it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just add tests!
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
@LeonStadelmann thanks a lot, looks great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Leon!
@selmanozleyen shall we remove the distinction of slow and non-slow tests now, wdyt? |
@MUCDK yeah maybe it makes more sense now. I can do that once this merges |
No description provided.