Skip to content

Fix Tests CI and reduce the computation of test_cellflow.py in general #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

selmanozleyen
Copy link
Collaborator

@selmanozleyen selmanozleyen commented Jul 14, 2025

Fixes #260

one note: I removed the time comparison for batched and non-batched computations since their solver steps had to be reduced.

Copy link

codecov bot commented Jul 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.42%. Comparing base (c574350) to head (e87763b).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            main     #261       +/-   ##
==========================================
+ Coverage   0.00%   76.42%   +76.42%     
==========================================
  Files         38       38               
  Lines       2727     2727               
  Branches       0      347      +347     
==========================================
+ Hits           0     2084     +2084     
+ Misses      2727      515     -2212     
- Partials       0      128      +128     

see 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@selmanozleyen
Copy link
Collaborator Author

selmanozleyen commented Jul 14, 2025

@MUCDK the non 3.12 runners are crashing (because of the same reasons as before I think). Maybe we should just keep them distinct? This way at least we'd reduce computation and test them to know they are at least working.

@MUCDK
Copy link
Collaborator

MUCDK commented Jul 15, 2025

That's strange, isn't it? They had passed in the split version, didn't they? But yeah, then let's keep them separate.

@selmanozleyen
Copy link
Collaborator Author

Since the split versions were only python 3.12 they passed. The ones that passed here are also the same

@MUCDK
Copy link
Collaborator

MUCDK commented Jul 15, 2025

I see. so what was your reasoning for 3.11 and 3.13 tests not passing?

@selmanozleyen
Copy link
Collaborator Author

selmanozleyen commented Jul 15, 2025

I see. so what was your reasoning for 3.11 and 3.13 tests not passing?

It might be simply due to the github runner capacity. When I tried those tests myself from the clusters they passed.

Also as a note if I did seperate also 3.11 and 3.13 I think they might pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove distinction of tests
2 participants