-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poisson Model #140
Poisson Model #140
Conversation
Tests fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I'd say this is very much done. Only some minor things I've spotted.
Most importantly, I'd say init_theta_scale
should really be removed and maybe we can reuse some functions by putting them into the base_glm
submodule. But that might be better to do once all the noise models are implemented and merged.
It appears that for the test that is failing, the threshold is .2 for the mean and the real average deviation is 0.27 - I've heard previously that these tests can be unreliable though so not sure how to proceed. A few other things:
bounds
method is derived so I copied that as well - is there something in the manuscript?scale
. I think given that 2/3 of the models that we use now deviate from the standard implementation, maybe all of this should be in kwargs? Not sure what the idiomatic python thing is to do.