Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make EhrData subclass AnnData #50

Merged
merged 14 commits into from
Oct 10, 2024
Merged

Make EhrData subclass AnnData #50

merged 14 commits into from
Oct 10, 2024

Conversation

flying-sheep
Copy link
Contributor

No description provided.

flying-sheep
flying-sheep commented Oct 10, 2024
View reviewed changes
Copy link
Contributor Author

@flying-sheep flying-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these should be cherry-picked even if we don’t merge this yet

src/ehrdata/core/ehrdata.py Show resolved Hide resolved
src/ehrdata/core/ehrdata.py Show resolved Hide resolved
src/ehrdata/core/ehrdata.py Show resolved Hide resolved
@flying-sheep flying-sheep marked this pull request as ready for review October 10, 2024 12:19
eroell
eroell approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@eroell eroell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks so much!

@eroell eroell mentioned this pull request Oct 10, 2024
Open
@eroell eroell merged commit a2b8215 into main Oct 10, 2024
6 checks passed
@eroell eroell deleted the subclass branch October 10, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eroell eroell eroell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flying-sheep @eroell