Skip to content

(fix): handle no docs in source code #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 2, 2025

Conversation

ilan-gold
Copy link
Contributor

See https://github.com/python/cpython/blob/main/Lib/inspect.py#L949-L1006 for the source code yielding the error

Error raised from CI here: scverse/anndata#1997

Under most circumstances, blanket catching an OSError seems like a bad idea, but I'm not sure ripping the messages out of the source code and checking them one-by-one is a much better idea, especially since OSError is the documented behavior: https://docs.python.org/3/library/inspect.html#inspect.getsourcelines

Copy link

codecov bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (334cbe0) to head (7247ab3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #214   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines          511       511           
=========================================
  Hits           511       511           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ilan-gold ilan-gold requested a review from flying-sheep June 2, 2025 10:06
@flying-sheep flying-sheep merged commit 33124c3 into main Jun 2, 2025
7 checks passed
@flying-sheep flying-sheep deleted the ig/fix_no_line_nos_builtin_source branch June 2, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants