fix(campaign): handle empty array stage description input

thematters · Aug 20, 2024 · 76ec46c · 76ec46c
1 parent 2b0e15b
commit 76ec46c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/mutations/campaign/putWritingChallenge.ts b/src/mutations/campaign/putWritingChallenge.ts
@@ -174,7 +174,10 @@ const resolver: GQLMutationResolvers['putWritingChallenge'] = async (
       campaign.id,
       stages.map((stage) => ({
         name: stage.name[0].text,
-        description: stage.description ? stage.description[0].text : '',
+        description:
+          stage.description && stage.description.length > 0
+            ? stage.description[0].text
+            : '',
         period: stage.period
           ? [stage.period.start, stage.period.end]
           : undefined,
@@ -191,7 +194,7 @@ const resolver: GQLMutationResolvers['putWritingChallenge'] = async (
             text: trans.text,
           })
         }
-        if (stage.description) {
+        if (stage.description && stage.description.length > 0) {
           for (const trans of stage.description) {
             await translationService.updateOrCreateTranslation({
               table: 'campaign_stage',

diff --git a/src/types/__test__/2/campaign.test.ts b/src/types/__test__/2/campaign.test.ts
@@ -129,6 +129,7 @@ describe('create or update wrting challenges', () => {
   const stages = [
     {
       name: translationsStageName1,
+      description: [],
       period: {
         start: new Date('2024-01-03'),
         end: new Date('2024-01-04'),