Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip @mention for article language resolver #4156

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

robertu7
Copy link
Contributor

@robertu7 robertu7 requested a review from a team as a code owner August 28, 2024 11:36
@robertu7 robertu7 requested a review from gary02 August 28, 2024 11:36
@robertu7 robertu7 merged commit 4ed6ddb into develop Aug 28, 2024
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/article-lang-strip-mentions branch August 28, 2024 12:10
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 60.89%. Comparing base (c87d453) to head (4e06540).
Report is 5 commits behind head on develop.

Files Patch % Lines
src/common/utils/mention.ts 25.00% 3 Missing ⚠️
src/queries/article/language.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4156      +/-   ##
===========================================
- Coverage    60.90%   60.89%   -0.01%     
===========================================
  Files          952      952              
  Lines        18742    18748       +6     
  Branches      3407     3407              
===========================================
+ Hits         11414    11416       +2     
- Misses        7275     7279       +4     
  Partials        53       53              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants