-
-
Notifications
You must be signed in to change notification settings - Fork 475
Fixes layout where title and close button overlap in RTL mode #1643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes layout where title and close button overlap in RTL mode #1643
Conversation
🦋 Changeset detectedLatest commit: cca00ec The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@Sandeep17262shra is attempting to deploy a commit to the Themesberg Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughSwitched modal header close button utility from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/ui/src/components/Modal/theme.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: 🧰 Build
🔇 Additional comments (1)
packages/ui/src/components/Modal/theme.ts (1)
48-48: Excellent fix for RTL support!The change from
ml-autotoms-autocorrectly uses Tailwind's logical property, ensuring the close button positions properly in both LTR and RTL text directions. This resolves the overlap issue in RTL mode while maintaining correct behavior in LTR mode.
|
@SutuSebastian can you please review this PR for the issue |
SutuSebastian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, but let's cover all the cases here as well, and replace space-x-2 in modalTheme.footer.base with gap-2.
Also please run bun changeset, select flowbite-react package and bump the version as patch
|
@SutuSebastian required changes done please review |
Fixes layout where title and close button overlap in RTL mode
Uses logical CSS property for text direction
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.