Skip to content

[DERCBOT-1404] Fix locale string interpretation#1975

Merged
assouktim merged 4 commits intotheopenconversationkit:masterfrom
CreditMutuelArkea:fix/locale-string-interpretation/DERCBOT-1404
Jan 14, 2026
Merged

[DERCBOT-1404] Fix locale string interpretation#1975
assouktim merged 4 commits intotheopenconversationkit:masterfrom
CreditMutuelArkea:fix/locale-string-interpretation/DERCBOT-1404

Conversation

@scezen
Copy link
Member

@scezen scezen commented Dec 30, 2025

Ticket : DERCBOT-1404

Details

  • Fixed locale parsing issue in RestConnector where legacy formats (ex: fr_FR) resulted in empty locale data.
  • Input locales are now sanitized (replacing _ with -) to ensure compatibility with BCP 47 standards before parsing.
  • nlpStats in Studio Analytics now correctly reflect the provided locale when testing via TVK or Postman.

@scezen scezen requested a review from assouktim January 2, 2026 22:55
assouktim

This comment was marked as duplicate.

Copy link
Contributor

@assouktim assouktim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The backend is fine. But there is a small bug on the frontend: you should notice that the language display in the user interface is not correct. To fix this, use the normalizeLocaleCode function.

@assouktim assouktim marked this pull request as ready for review January 12, 2026 15:03
@vsct-jburet vsct-jburet requested a review from Copilot January 13, 2026 09:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.

@scezen scezen requested a review from assouktim January 14, 2026 08:58
Copy link
Contributor

@assouktim assouktim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@assouktim assouktim merged commit f71a007 into theopenconversationkit:master Jan 14, 2026
7 checks passed
@assouktim assouktim deleted the fix/locale-string-interpretation/DERCBOT-1404 branch January 14, 2026 10:41
@zigzago zigzago added this to the 25.10.4 milestone Jan 14, 2026
@zigzago zigzago added the bug label Jan 14, 2026
Copy link
Member

@rkuffer rkuffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok pour moi coté TS. Merci

@rkuffer
Copy link
Member

rkuffer commented Jan 15, 2026

Ah j'arrive après la bataille ; )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants