Skip to content

acookin/trustcenter #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

acookin/trustcenter #818

wants to merge 4 commits into from

Conversation

acookin
Copy link
Member

@acookin acookin commented Jun 8, 2025

  • trust center stuff
  • stuff
  • tc stuff

func (t TrustCenterSetting) Mixin() []ent.Mixin {
return mixinConfig{
additionalMixins: []ent.Mixin{
newOrgOwnedMixin(t),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is still a draft, but thought I'd comment early on this - instead of having this as org owned, it should be "owned" by the trust center object. We have an annotation you can use, if you look at groups as an example, I think this should easily be able to work the same. And then you also don't need the edge to trust center settings on the organization object.

		entfga.SettingsChecks("group"),

Copy link
Member

@golanglemonade golanglemonade Jun 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would set that ^ first, and then you can add this to your policy on a second run:

entfga.CheckEditAccess[*generated.TrustCenterSettingMutation](),

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the first generate, there's a failure with the authcheck dereferencing a string, and I honestly do not understand why. Not sure if i need to generate from scratch, but not even sure how to do that because if i delete the generated directory(s), i get massive errors

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I retried this whole thing bc i was going around in circles, this seems to fail with different errors, so that's fun:
#822

@acookin acookin force-pushed the acookin/trustcenter branch from 43573c5 to 15e1e77 Compare June 8, 2025 23:12
@github-actions github-actions bot removed the config label Jun 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants