[GCS] Add option to stream reads #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rickclephas if you could rebase on latest 3.x, that will probably make the tests green again. |
rickclephas
force-pushed
the
feature/gcs-streaming-reads
branch
from
78b0018 to
91ecc62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
streamReadsoption to theGoogleCloudStorageAdapter(similar to theAwsS3V3Adapter).It makes sure that
readStreamwill actually stream the read instead of downloading the whole file.When set to
truethe behaviour will be the same as with the official GCS StreamWrapper.To preserve backwards compatibility the default value is set to
false, this could be changed totruein a future version.