Skip to content

Feat/polygon metadata registry #1694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

adjisb
Copy link
Contributor

@adjisb adjisb commented May 6, 2025

Description

https://internal-jira.atlassian.net/browse/LR-41

Summary by CodeRabbit

  • New Features

    • Added deployment artifacts for new proxy contracts on Polygon, enabling upgradeable and admin-controlled smart contracts.
    • Introduced new functions for metadata management, ownership transfer, royalty management, and token existence checks.
    • Expanded event and error reporting to improve transparency and contract interaction feedback.
  • Improvements

    • Enhanced function and parameter naming for clarity and consistency across contract interfaces.

@adjisb adjisb requested a review from a team as a code owner May 6, 2025 14:27
@adjisb adjisb force-pushed the feat/polygon_metadata_registry branch from cf9ac31 to 3dfd0a5 Compare May 6, 2025 14:29
@adjisb adjisb force-pushed the feat/polygon_metadata_registry branch from 3dfd0a5 to 380e8ca Compare June 19, 2025 11:41
Copy link

coderabbitai bot commented Jun 19, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Four new or updated deployment artifacts for smart contracts on Polygon were added or modified. These include deployment JSONs for LandMetadataRegistry, its proxy, PolygonLand, and PolygonLand_V2. The updates introduce new events, errors, functions, improved parameter naming, and updated implementation addresses, reflecting enhanced proxy and contract management capabilities.

Changes

File(s) Change Summary
.../deployments/polygon/LandMetadataRegistry.json
.../LandMetadataRegistry_Proxy.json
Added deployment artifacts for the LandMetadataRegistry proxy and its implementation, including full ABIs, bytecode, deployment receipts, and metadata. Exposes admin/upgrade functions, role and metadata management, and events/errors for transparent upgradeable proxy pattern.
.../deployments/polygon/PolygonLand.json Updated deployment artifact for PolygonLand with new events, custom errors, additional functions for metadata/ownership/royalty management, improved parameter naming, and a new implementation address. Incremented deployment count.
.../deployments/polygon/PolygonLand_V2.json Added deployment artifact for PolygonLand_V2 as a transparent upgradeable proxy, including ABI, events, admin/upgrade functions, and metadata. Provides admin-controlled upgradeability and initialization.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Proxy (Upgradeable)
    participant Implementation

    User->>Proxy (Upgradeable): Call function (e.g., setMetadata)
    Proxy (Upgradeable)->>Implementation: Delegate call (unless admin)
    Implementation-->>Proxy (Upgradeable): Return result
    Proxy (Upgradeable)-->>User: Return result

    Admin->>Proxy (Upgradeable): Call upgradeTo(newImpl)
    Proxy (Upgradeable)->>Proxy (Upgradeable): Update implementation address
    Proxy (Upgradeable)-->>Admin: Emit Upgraded event
Loading

Poem

In Polygon fields where smart contracts grow,
Proxies now flourish, with upgrades in tow.
New errors and events, like carrots, abound,
Ownership and metadata, neatly tracked and sound.
With every deploy, the garden expands—
A rabbit’s delight in these digital lands!
🥕✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 745c998 and 380e8ca.

📒 Files selected for processing (4)
  • packages/deploy/deployments/polygon/LandMetadataRegistry.json (1 hunks)
  • packages/deploy/deployments/polygon/LandMetadataRegistry_Proxy.json (1 hunks)
  • packages/deploy/deployments/polygon/PolygonLand.json (28 hunks)
  • packages/deploy/deployments/polygon/PolygonLand_V2.json (1 hunks)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@adjisb
Copy link
Contributor Author

adjisb commented Jun 19, 2025

Replaced by: #1711

@adjisb adjisb closed this Jun 19, 2025
@adjisb adjisb deleted the feat/polygon_metadata_registry branch June 19, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant