feat(ts): write array data #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements array data writing functionality for the TypeScript implementation of ngff-zarr, transitioning from placeholder code to a complete chunk-based parallel writing system.
Key Changes:
- Replaced placeholder array writing code with a comprehensive chunk-based implementation
- Added parallel processing support using p-queue for concurrent chunk writes
- Implemented type conversion utilities to handle different data types correctly
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
ts/src/io/to_ngff_zarr.ts |
Complete rewrite of array writing logic with parallel chunk processing and type conversion |
ts/src/utils/create_queue.ts |
New utility for creating concurrent processing queues with hardware-aware concurrency |
ts/deno.json |
Added p-queue dependency for parallel processing |
ts/test/from_ngff_zarr_test.ts |
Commented out debug logging for cleaner test output |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
We need 2.4 for `deno bundle` -- conda-forge currently only has 2.3.
Work around p-queue dep esm difficulties.
For test data download.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.