-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross chain transactions #586
Open
codypharm
wants to merge
111
commits into
thirdweb-dev:main
Choose a base branch
from
alfheimrShiven:cross-chain-transactions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Cross chain transactions #586
codypharm
wants to merge
111
commits into
thirdweb-dev:main
from
alfheimrShiven:cross-chain-transactions
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Account social recovery
… is failing [Buggy commit]
Removed usage of DeploySmartAccountUtilContracts script since it was buggy.
… AccountGuardianTest till deployment of util contracts soln is found
Account social recovery update: AccountLock as single instance
Account Lock request creation, signature evaluation and execution
…n by BaseAccountFactory
Script for deploying all smart-wallet util contracts at once
…unt locking functionality, Chainlink automation commented out(temp)
Sending AccountLock address while initializing Account clones
…-upgradeable AccountFactory
[Fix]: Stack too deep error
Email verification before creating Account recovery request
…ipt for both Anvil & Sepolia, passed email throughout smart account creation chain
Util contracts deploy script updates: 1. Moved smart account creation to deploy script because AccountGuardian & AccountRecovery contracts are deployed only during smart account creation AccountFactory::createAccount(...) 2. Fixed Stack Too Deep error by restricting the return of CCIP contracts. Note: CCIP contracts will be deployed but not returned as of now. 3. Made the deploy script dynamic for both Anvil & Sepolia chains. 4. Passed the email param used when creating a smart account, across the whole smart account creation chain. 5. Updated the deploy script test.
Account Recovery contract unit test suite
…Recovery contract
[Fix] `Account::updateAdmin()` function signature and call fix
…ted post account recovery
AccountRecovery unit tests completed. Coverage: 92%
reduced params for commitEmailVerificationHash() and updated test
updated Readme: Problem statement, Architecture
Readme updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.