Bump target to iOS7, introduce nullability, always async, and separate storage from queue #22
Conversation
added nullability added EDQueueJob instead of dictionary + keys (for user data it still provides userInfo dictionary, nullable)
Updated Code & Example Added basic Queue tests README updated accordingly
|
Very cool. Taking a look now. |
| s.authors = {'Andrew Sliwinski' => '[email protected]', 'Francois Lambert' => '[email protected]'} | ||
| s.source = { :git => 'https://github.com/thisandagain/queue.git', :tag => 'v0.7.1' } | ||
| s.platform = :ios, '5.0' | ||
| s.homepage = 'https://github.com/gelosi/queue' |
There was a problem hiding this comment.
Why would we move the location of the homepage and repo?
There was a problem hiding this comment.
I've set it to mine now to use it already, but if you will accept the changes in the end (I'm still on it) I'd be happy to keep original link to repo.
|
Overall this is great. Thanks for pulling this together @gelosi . I left you a few comments and notes for discussion. |
|
Hi Andrew Cool! Thank you for a quick feedback. This is a very start. I will try to offer some idea on 'built-in' persistent storage. As I suppose apps which using already some sqlite wrapper different from FMDB might stay aside. That is my approach. Ideally - having ready-to go fmdb submodule (as default dependency). And reduce persistent storage interface requirements to CRUD :) — On Fri, Feb 19, 2016 at 7:04 PM, Andrew Sliwinski
|
…of EDQueueJob; introduced EDQueueStoredJob protocol (to be renamed)
|
@thisandagain so, shaping better approach. Have a look, please. |
…ueue lost retryCount respectively; More Tests!
…etchNextJobTimeInterval`). Also, fixed critical bug - a race condition in queue. So, job might be executed two times :/ Hola TDD!
| @end | ||
|
|
||
|
|
||
| NS_ASSUME_NONNULL_END |
| @property(nonatomic, readonly) EDQueueJob *job; | ||
|
|
||
| @property(nonatomic, readonly, nullable) NSNumber *jobID; | ||
| @property(nonatomic, readonly, nullable) NSNumber *attempts; |
There was a problem hiding this comment.
Let's just use @0 as a default value and avoid nil.
…will get it's own :)
…EDQueueStorageItem protocol (and EDQueueStorageEngineJob respectively), blocked +new method from EDQueueJob ^^,
…r NSCoded objects)
Hi! Have a look please
I've updated README accordingly. Idea is: