Replace inherit with explicit secret passing #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inherit won't work in our use-case. We have to pass OSS_SLACK_NOTIFICATION_WEBHOOK_URL explicitly for the job to use it properly.
Amdrel
requested review from
dustinsgoodman
and removed request for
dustinsgoodman
Amdrel
changed the title
Amdrel
changed the title
dustinsgoodman
approved these changes
Jun 17, 2024
|
I could have sworn we discussed this in a huddle, but that inherit feature
doesn't work with organization-level secrets if I recall correctly.
…On Mon, Jun 17, 2024 at 11:39 AM Dustin Goodman ***@***.***> wrote:
***@***.**** approved this pull request.
I'd love to understand why but this seems reasonable.
—
Reply to this email directly, view it on GitHub
<#54 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABA5XZXDMSCCD252OFCU4HDZH4UNRAVCNFSM6AAAAABJK6ZPFOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMRTGY2TENRXGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inherit won't work in our use-case. We have to pass OSS_SLACK_NOTIFICATION_WEBHOOK_URL explicitly for the job to use it properly.