Skip to content

fix: fix text overflow on long text #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2024
Merged

Conversation

thisissandipp
Copy link
Owner

@thisissandipp thisissandipp commented Aug 11, 2024

Description

  • fix: fix long text overflow (by using a WidgetSpan for the BlinkingCursor instead of passing it as a child for Row)

Fixes #6

Type of Pull Request

  • 🐞 Bug fix (Non-breaking change which fixes issue)
  • ✨ Feature (Non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🛠️ Code refactoring (No code changes, no API changes)
  • 🏗️ Build configuration change
  • 📚 Documentation
  • 🧹 Chore
  • 💡 Other... Please describe

Pull Request Checklist

  • 🚀 I have reviewed my own code and ensured it follows the project's coding standards.
  • 🧪 I have added unit tests (if necessary) and they pass.
  • 📚 I have updated documentation (if necessary).
  • 🤖 I have provided clear and informative commit messages.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bfba879) to head (1d3d379).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #10   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          117       118    +1     
=========================================
+ Hits           117       118    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thisissandipp thisissandipp self-assigned this Aug 11, 2024
@thisissandipp thisissandipp linked an issue Aug 11, 2024 that may be closed by this pull request
@thisissandipp thisissandipp merged commit 5a8e37e into main Aug 11, 2024
1 check passed
@thisissandipp thisissandipp deleted the fix/long-text-overflow branch September 23, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Softwrap is not effective
2 participants