Skip to content

fix: use characters api to render unicode #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 22, 2024
Merged

Conversation

thisissandipp
Copy link
Owner

Description

  • fix: use characters api to render unicode characters

Fixes #11

Type of Pull Request

  • 🐞 Bug fix (Non-breaking change which fixes issue)
  • ✨ Feature (Non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to change)
  • πŸ› οΈ Code refactoring (No code changes, no API changes)
  • πŸ—οΈ Build configuration change
  • πŸ“š Documentation
  • 🧹 Chore
  • πŸ’‘ Other... Please describe

Pull Request Checklist

  • πŸš€ I have reviewed my own code and ensured it follows the project's coding standards.
  • πŸ§ͺ I have added unit tests (if necessary) and they pass.
  • πŸ“š I have updated documentation (if necessary).
  • πŸ€– I have provided clear and informative commit messages.

@thisissandipp thisissandipp self-assigned this Sep 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 100.00%. Comparing base (9145dac) to head (d2d51d7).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #15   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          118       118           
=========================================
  Hits           118       118           
Flag Coverage Ξ”
100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@thisissandipp thisissandipp merged commit 8479e9c into main Sep 22, 2024
4 checks passed
@thisissandipp thisissandipp deleted the fix/string-unicode branch September 22, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: string is not well-formed UTF-16 (emoji?)
2 participants